components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

index c8b06e8c64d4d47e09a832cf95c806e87135ed9b..68f152e67178306031f2565194a18aaae061b728 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

@@ -92,7 +92,7 @@ class DataReductionProxySettings

static bool IsProxyKeySetOnCommandLine();

DataReductionProxySettings(DataReductionProxyParams* params);

- virtual ~DataReductionProxySettings();

+ ~DataReductionProxySettings() override;

DataReductionProxyParams* params() const {

return params_.get();

@@ -179,7 +179,7 @@ class DataReductionProxySettings

ContentLengthList GetDailyContentLengths(const char* pref_name);

// net::URLFetcherDelegate:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

protected:

void InitPrefMembers();

@@ -269,7 +269,7 @@ class DataReductionProxySettings

TestSetProxyConfigsHoldback);

// NetworkChangeNotifier::IPAddressObserver:

- virtual void OnIPAddressChanged() override;

+ void OnIPAddressChanged() override;

void OnProxyEnabledPrefChange();

void OnProxyAlternativeEnabledPrefChange();