components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h ('k') | components/dom_distiller/content/distiller_page_web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

index 3681fe0c8b172f3bc8065355e010eaa8e0cefe48..84fe8cd5d9aee57c123903b33eae24c476076cbc 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h

@@ -47,7 +47,7 @@ class DataReductionProxyUsageStats

DataReductionProxyUsageStats(

DataReductionProxyParams* params,

const scoped_refptr<base::MessageLoopProxy>& ui_thread_proxy);

- virtual ~DataReductionProxyUsageStats();

+ ~DataReductionProxyUsageStats() override;

// Sets the callback to be called on the UI thread when the unavailability

// status has changed.

@@ -108,7 +108,7 @@ class DataReductionProxyUsageStats

void RecordMissingViaHeaderBytes(net::URLRequest* request);

// NetworkChangeNotifier::NetworkChangeObserver:

- virtual void OnNetworkChanged(

+ void OnNetworkChanged(

net::NetworkChangeNotifier::ConnectionType type) override;

// Called when request counts change. Resets counts if they exceed thresholds,