components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_params_test_utils.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc

index ee53355c39c6ed2a81c4e64c0681a1a61c0398e5..1ff3832653655d17ef42886509f4b3a2831e3f46 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc

@@ -54,7 +54,7 @@ class TestDataReductionProxyNetworkDelegate : public net::NetworkDelegate {

bypass_type_(bypass_type) {

}

- virtual int OnHeadersReceived(

+ int OnHeadersReceived(

URLRequest* request,

const net::CompletionCallback& callback,

const HttpResponseHeaders* original_response_headers,

@@ -820,10 +820,10 @@ TEST_F(DataReductionProxyProtocolTest,

class BadEntropyProvider : public base::FieldTrial::EntropyProvider {

public:

- virtual ~BadEntropyProvider() {}

+ ~BadEntropyProvider() override {}

- virtual double GetEntropyForTrial(const std::string& trial_name,

- uint32 randomization_seed) const override {

+ double GetEntropyForTrial(const std::string& trial_name,

+ uint32 randomization_seed) const override {

return 0.5;

}

};