components/autofill/core/browser/webdata/autofill_change.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_change.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/test_personal_data_manager.h ('k') | components/autofill/core/browser/webdata/autofill_profile_syncable_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_change.h

diff --git a/components/autofill/core/browser/webdata/autofill_change.h b/components/autofill/core/browser/webdata/autofill_change.h

index fe421615e41c748bb41b429c0b37a2ea36a5bbcd..0e856570f94d66efa173cfb37dacb385df5051eb 100644

--- a/components/autofill/core/browser/webdata/autofill_change.h

+++ b/components/autofill/core/browser/webdata/autofill_change.h

@@ -41,7 +41,7 @@ class GenericAutofillChange {

class AutofillChange : public GenericAutofillChange<AutofillKey> {

public:

AutofillChange(Type type, const AutofillKey& key);

- virtual ~AutofillChange();

+ ~AutofillChange() override;

bool operator==(const AutofillChange& change) const {

return type() == change.type() && key() == change.key();

}

@@ -60,7 +60,7 @@ class AutofillProfileChange : public GenericAutofillChange<std::string> {

AutofillProfileChange(Type type,

const std::string& key,

const AutofillProfile* profile);

- virtual ~AutofillProfileChange();

+ ~AutofillProfileChange() override;

const AutofillProfile* profile() const { return profile_; }

bool operator==(const AutofillProfileChange& change) const;