components/autofill/core/browser/webdata/autofill_profile_syncable_service.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_change.h ('k') | components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

diff --git a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

index 7127a84018213a305ba5a5573724047283372a3a..6dba5f2d1471e492e90ec7291eadf444ce9f225f 100644

--- a/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

+++ b/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h

@@ -50,7 +50,7 @@ class AutofillProfileSyncableService

public AutofillWebDataServiceObserverOnDBThread,

public base::NonThreadSafe {

public:

- virtual ~AutofillProfileSyncableService();

+ ~AutofillProfileSyncableService() override;

// Creates a new AutofillProfileSyncableService and hangs it off of

// |web_data_service|, which takes ownership. This method should only be

@@ -67,21 +67,19 @@ class AutofillProfileSyncableService

static syncer::ModelType model_type() { return syncer::AUTOFILL_PROFILE; }

// syncer::SyncableService implementation.

- virtual syncer::SyncMergeResult MergeDataAndStartSyncing(

+ syncer::SyncMergeResult MergeDataAndStartSyncing(

syncer::ModelType type,

const syncer::SyncDataList& initial_sync_data,

scoped_ptr<syncer::SyncChangeProcessor> sync_processor,

scoped_ptr<syncer::SyncErrorFactory> sync_error_factory) override;

- virtual void StopSyncing(syncer::ModelType type) override;

- virtual syncer::SyncDataList GetAllSyncData(

- syncer::ModelType type) const override;

- virtual syncer::SyncError ProcessSyncChanges(

+ void StopSyncing(syncer::ModelType type) override;

+ syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override;

+ syncer::SyncError ProcessSyncChanges(

const tracked_objects::Location& from_here,

const syncer::SyncChangeList& change_list) override;

// AutofillWebDataServiceObserverOnDBThread implementation.

- virtual void AutofillProfileChanged(

- const AutofillProfileChange& change) override;

+ void AutofillProfileChanged(const AutofillProfileChange& change) override;

// Provides a StartSyncFlare to the SyncableService. See

// sync_start_util for more.