components/autofill/core/browser/test_personal_data_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/test_personal_data_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/test_autofill_driver.h ('k') | components/autofill/core/browser/webdata/autofill_change.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/test_personal_data_manager.h

diff --git a/components/autofill/core/browser/test_personal_data_manager.h b/components/autofill/core/browser/test_personal_data_manager.h

index ede08aa3979bde87ee610741cda7242f04b06251..ac17657efb8dab2eb5ffb078a22d980d676db1f0 100644

--- a/components/autofill/core/browser/test_personal_data_manager.h

+++ b/components/autofill/core/browser/test_personal_data_manager.h

@@ -17,7 +17,7 @@ namespace autofill {

class TestPersonalDataManager : public PersonalDataManager {

public:

TestPersonalDataManager();

- virtual ~TestPersonalDataManager();

+ ~TestPersonalDataManager() override;

void AddTestingProfile(AutofillProfile* profile);

@@ -26,18 +26,17 @@ class TestPersonalDataManager : public PersonalDataManager {

// |credit_card|.

void AddTestingCreditCard(CreditCard* credit_card);

- virtual const std::vector<AutofillProfile*>& GetProfiles() const override;

- virtual const std::vector<AutofillProfile*>& web_profiles() const override;

- virtual const std::vector<CreditCard*>& GetCreditCards() const override;

+ const std::vector<AutofillProfile*>& GetProfiles() const override;

+ const std::vector<AutofillProfile*>& web_profiles() const override;

+ const std::vector<CreditCard*>& GetCreditCards() const override;

- virtual std::string SaveImportedProfile(

+ std::string SaveImportedProfile(

const AutofillProfile& imported_profile) override;

- virtual std::string SaveImportedCreditCard(

+ std::string SaveImportedCreditCard(

const CreditCard& imported_credit_card) override;

- virtual std::string CountryCodeForCurrentTimezone() const override;

- virtual const std::string& GetDefaultCountryCodeForNewAddress() const

- override;

+ std::string CountryCodeForCurrentTimezone() const override;

+ const std::string& GetDefaultCountryCodeForNewAddress() const override;

void set_timezone_country_code(const std::string& timezone_country_code) {

timezone_country_code_ = timezone_country_code;