Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 665763002: Oilpan: move context menu providers to the heap. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, mkwst+moarreviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: move context menu providers to the heap. Avoids keeping Persistent<> references on CustomContextMenuProvider. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183966

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated GC_PLUGIN_IGNORE() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -59 lines) Patch
M Source/core/inspector/InspectorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 5 chunks +48 lines, -33 lines 0 comments Download
M Source/core/page/ContextMenuController.h View 4 chunks +7 lines, -6 lines 0 comments Download
M Source/core/page/ContextMenuController.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/ContextMenuProvider.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/page/CustomContextMenuProvider.h View 2 chunks +9 lines, -6 lines 0 comments Download
M Source/core/page/CustomContextMenuProvider.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/web/InspectorClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Note: ~FrontendMenuProvider has been emptied; the call to contextMenuCleared() served no ...
6 years, 2 months ago (2014-10-19 19:18:08 UTC) #2
sof
https://codereview.chromium.org/665763002/diff/1/Source/core/inspector/InspectorFrontendHost.cpp File Source/core/inspector/InspectorFrontendHost.cpp (right): https://codereview.chromium.org/665763002/diff/1/Source/core/inspector/InspectorFrontendHost.cpp#newcode130 Source/core/inspector/InspectorFrontendHost.cpp:130: GC_PLUGIN_IGNORE("") Will update to refer to http://crbug.com/424962 before finalizing ...
6 years, 2 months ago (2014-10-19 19:36:55 UTC) #3
haraken
LGTM I'm getting to realize that it's important to remove Persistent handles from hot call ...
6 years, 2 months ago (2014-10-20 02:11:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665763002/20001
6 years, 2 months ago (2014-10-20 05:40:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 07:13:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183966

Powered by Google App Engine
This is Rietveld 408576698