Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: Source/core/page/CustomContextMenuProvider.h

Issue 665763002: Oilpan: move context menu providers to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated GC_PLUGIN_IGNORE() Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/ContextMenuProvider.h ('k') | Source/core/page/CustomContextMenuProvider.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CustomContextMenuProvider.h
diff --git a/Source/core/page/CustomContextMenuProvider.h b/Source/core/page/CustomContextMenuProvider.h
index 9a5fab0948b5de6bb1b0336e8e49025abd6947fe..a59a0913bc760c9609ed2ff55e7acccf6f9fefaa 100644
--- a/Source/core/page/CustomContextMenuProvider.h
+++ b/Source/core/page/CustomContextMenuProvider.h
@@ -18,14 +18,17 @@ class HTMLMenuItemElement;
class CustomContextMenuProvider final : public ContextMenuProvider {
public:
- static PassRefPtr<CustomContextMenuProvider> create(HTMLMenuElement& menu, HTMLElement& subject)
+ virtual ~CustomContextMenuProvider();
+
+ static PassRefPtrWillBeRawPtr<CustomContextMenuProvider> create(HTMLMenuElement& menu, HTMLElement& subject)
{
- return adoptRef(new CustomContextMenuProvider(menu, subject));
+ return adoptRefWillBeNoop(new CustomContextMenuProvider(menu, subject));
}
+ virtual void trace(Visitor*);
+
private:
CustomContextMenuProvider(HTMLMenuElement&, HTMLElement&);
- virtual ~CustomContextMenuProvider();
virtual void populateContextMenu(ContextMenu*) override;
virtual void contextMenuItemSelected(const ContextMenuItem*) override;
@@ -35,9 +38,9 @@ private:
void appendMenuItem(HTMLMenuItemElement*, ContextMenu&);
HTMLElement* menuItemAt(unsigned menuId);
- RefPtrWillBePersistent<HTMLMenuElement> m_menu;
- RefPtrWillBePersistent<HTMLElement> m_subjectElement;
- WillBePersistentHeapVector<RefPtrWillBeMember<HTMLElement> > m_menuItems;
+ RefPtrWillBeMember<HTMLMenuElement> m_menu;
+ RefPtrWillBeMember<HTMLElement> m_subjectElement;
+ WillBeHeapVector<RefPtrWillBeMember<HTMLElement> > m_menuItems;
};
} // namespace blink
« no previous file with comments | « Source/core/page/ContextMenuProvider.h ('k') | Source/core/page/CustomContextMenuProvider.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698