Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: Source/web/WebViewImpl.h

Issue 665763002: Oilpan: move context menu providers to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated GC_PLUGIN_IGNORE() Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/InspectorClientImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 virtual bool scrollBy(const WebFloatSize& delta, const WebFloatSize& velocit y) override; 346 virtual bool scrollBy(const WebFloatSize& delta, const WebFloatSize& velocit y) override;
347 347
348 // Handles context menu events orignated via the the keyboard. These 348 // Handles context menu events orignated via the the keyboard. These
349 // include the VK_APPS virtual key and the Shift+F10 combine. Code is 349 // include the VK_APPS virtual key and the Shift+F10 combine. Code is
350 // based on the Webkit function bool WebView::handleContextMenuEvent(WPARAM 350 // based on the Webkit function bool WebView::handleContextMenuEvent(WPARAM
351 // wParam, LPARAM lParam) in webkit\webkit\win\WebView.cpp. The only 351 // wParam, LPARAM lParam) in webkit\webkit\win\WebView.cpp. The only
352 // significant change in this function is the code to convert from a 352 // significant change in this function is the code to convert from a
353 // Keyboard event to the Right Mouse button down event. 353 // Keyboard event to the Right Mouse button down event.
354 bool sendContextMenuEvent(const WebKeyboardEvent&); 354 bool sendContextMenuEvent(const WebKeyboardEvent&);
355 355
356 void showContextMenuAtPoint(float x, float y, PassRefPtr<ContextMenuProvider >); 356 void showContextMenuAtPoint(float x, float y, PassRefPtrWillBeRawPtr<Context MenuProvider>);
357 357
358 // Notifies the WebView that a load has been committed. isNewNavigation 358 // Notifies the WebView that a load has been committed. isNewNavigation
359 // will be true if a new session history item should be created for that 359 // will be true if a new session history item should be created for that
360 // load. isNavigationWithinPage will be true if the navigation does 360 // load. isNavigationWithinPage will be true if the navigation does
361 // not take the user away from the current page. 361 // not take the user away from the current page.
362 void didCommitLoad(bool isNewNavigation, bool isNavigationWithinPage); 362 void didCommitLoad(bool isNewNavigation, bool isNavigationWithinPage);
363 363
364 // Indicates two things: 364 // Indicates two things:
365 // 1) This view may have a new layout now. 365 // 1) This view may have a new layout now.
366 // 2) Calling layout() is a no-op. 366 // 2) Calling layout() is a no-op.
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
755 float m_topControlsLayoutHeight; 755 float m_topControlsLayoutHeight;
756 }; 756 };
757 757
758 // We have no ways to check if the specified WebView is an instance of 758 // We have no ways to check if the specified WebView is an instance of
759 // WebViewImpl because WebViewImpl is the only implementation of WebView. 759 // WebViewImpl because WebViewImpl is the only implementation of WebView.
760 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 760 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
761 761
762 } // namespace blink 762 } // namespace blink
763 763
764 #endif 764 #endif
OLDNEW
« no previous file with comments | « Source/web/InspectorClientImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698