chrome/browser/media/webrtc_log_uploader.h - Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_log_uploader.h

Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc ('K') | « chrome/browser/media/native_desktop_media_list_unittest.cc ('k') | chrome/browser/media/webrtc_logging_handler_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_log_uploader.h

diff --git a/chrome/browser/media/webrtc_log_uploader.h b/chrome/browser/media/webrtc_log_uploader.h

index ae65c27f51fe55b9e81f5f8574b58c7b716846e3..dd9c916e2951a63f7e94e8632f50115dfecf2e22 100644

--- a/chrome/browser/media/webrtc_log_uploader.h

+++ b/chrome/browser/media/webrtc_log_uploader.h

@@ -48,12 +48,13 @@ struct WebRtcLogUploadDoneData {

class WebRtcLogUploader : public net::URLFetcherDelegate {

public:

WebRtcLogUploader();

- virtual ~WebRtcLogUploader();

+ ~WebRtcLogUploader() override;

// net::URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

- virtual void OnURLFetchUploadProgress(const net::URLFetcher* source,

- int64 current, int64 total) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchUploadProgress(const net::URLFetcher* source,

+ int64 current,

+ int64 total) override;

// Returns true is number of logs limit is not reached yet. Increases log

// count if true is returned. Must be called before UploadLog().