Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 665053002: App launcher: Fix warning log on unresolvable relative paths. (Closed)

Created:
6 years, 2 months ago by kinaba
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

App launcher: Fix warning log on unresolvable relative paths. In the current implementation, the helper function DoMakePathAbsolute may rewrite the input even in the case of failure, which makes the warning log less readable. BUG=none TEST=./chrome --app --app-id=someapp --enable-logging=stderr non/existing/path Committed: https://crrev.com/6e0570b6c5c46a19d4b65847b39cc6a860157eba Cr-Commit-Position: refs/heads/master@{#300424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M apps/launcher.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kinaba
PTAL. Not at all critical but I just felt a bit uneasy when I saw ...
6 years, 2 months ago (2014-10-20 09:48:36 UTC) #2
Yoyo Zhou
I think benwells is a better reviewer for this.
6 years, 2 months ago (2014-10-20 20:57:37 UTC) #4
benwells
lgtm
6 years, 2 months ago (2014-10-21 05:28:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665053002/1
6 years, 2 months ago (2014-10-21 05:31:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 05:43:41 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 05:44:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e0570b6c5c46a19d4b65847b39cc6a860157eba
Cr-Commit-Position: refs/heads/master@{#300424}

Powered by Google App Engine
This is Rietveld 408576698