App launcher: Fix warning log on unresolvable relative paths.

apps/launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/launcher.h"
 
 #include <set>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 53 matching lines @@
 
 const char kFallbackMimeType[] = "application/octet-stream";
 
 bool DoMakePathAbsolute(const base::FilePath& current_directory,
                         base::FilePath* file_path) {
   DCHECK(file_path);
   if (file_path->IsAbsolute())
     return true;
 
   if (current_directory.empty()) {
-    *file_path = base::MakeAbsoluteFilePath(*file_path);
-    return !file_path->empty();
+    base::FilePath absolute_path = base::MakeAbsoluteFilePath(*file_path);
+    if (absolute_path.empty())
+      return false;
+    *file_path = absolute_path;
+    return true;
   }
 
   if (!current_directory.IsAbsolute())
     return false;
 
   *file_path = current_directory.Append(*file_path);
   return true;
 }
 
 // Helper method to launch the platform app |extension| with no data. This
@@ skipping 316 matching lines @@
 void LaunchPlatformAppWithUrl(Profile* profile,
                               const Extension* extension,
                               const std::string& handler_id,
                               const GURL& url,
                               const GURL& referrer_url) {
   AppRuntimeEventRouter::DispatchOnLaunchedEventWithUrl(
       profile, extension, handler_id, url, referrer_url);
 }
 
 }  // namespace apps