Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2440)

Unified Diff: apps/launcher.cc

Issue 665053002: App launcher: Fix warning log on unresolvable relative paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/launcher.cc
diff --git a/apps/launcher.cc b/apps/launcher.cc
index a4272a69b6e5e1079d1498bc278a8063048f1ea7..50cdf5de6099eea7f5940f25db90304d375fdfbb 100644
--- a/apps/launcher.cc
+++ b/apps/launcher.cc
@@ -71,8 +71,11 @@ bool DoMakePathAbsolute(const base::FilePath& current_directory,
return true;
if (current_directory.empty()) {
- *file_path = base::MakeAbsoluteFilePath(*file_path);
- return !file_path->empty();
+ base::FilePath absolute_path = base::MakeAbsoluteFilePath(*file_path);
+ if (absolute_path.empty())
+ return false;
+ *file_path = absolute_path;
+ return true;
}
if (!current_directory.IsAbsolute())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698