Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: extensions/common/permissions/settings_override_permission.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/settings_override_permission.h
diff --git a/extensions/common/permissions/settings_override_permission.h b/extensions/common/permissions/settings_override_permission.h
index 8c98da958ab949f6defa002387dc36ea0372f15b..90dc2cc3a33f3ee793b4bcca4cd7912304553075 100644
--- a/extensions/common/permissions/settings_override_permission.h
+++ b/extensions/common/permissions/settings_override_permission.h
@@ -17,26 +17,25 @@ class SettingsOverrideAPIPermission : public APIPermission {
public:
SettingsOverrideAPIPermission(const APIPermissionInfo* permission,
const std::string& setting_value);
- virtual ~SettingsOverrideAPIPermission();
+ ~SettingsOverrideAPIPermission() override;
// APIPermission overrides.
- virtual bool HasMessages() const override;
- virtual PermissionMessages GetMessages() const override;
- virtual bool Check(const APIPermission::CheckParam* param) const override;
- virtual bool Contains(const APIPermission* rhs) const override;
- virtual bool Equal(const APIPermission* rhs) const override;
- virtual bool FromValue(
- const base::Value* value,
- std::string* error,
- std::vector<std::string>* unhandled_permissions) override;
- virtual scoped_ptr<base::Value> ToValue() const override;
- virtual APIPermission* Clone() const override;
- virtual APIPermission* Diff(const APIPermission* rhs) const override;
- virtual APIPermission* Union(const APIPermission* rhs) const override;
- virtual APIPermission* Intersect(const APIPermission* rhs) const override;
- virtual void Write(IPC::Message* m) const override;
- virtual bool Read(const IPC::Message* m, PickleIterator* iter) override;
- virtual void Log(std::string* log) const override;
+ bool HasMessages() const override;
+ PermissionMessages GetMessages() const override;
+ bool Check(const APIPermission::CheckParam* param) const override;
+ bool Contains(const APIPermission* rhs) const override;
+ bool Equal(const APIPermission* rhs) const override;
+ bool FromValue(const base::Value* value,
+ std::string* error,
+ std::vector<std::string>* unhandled_permissions) override;
+ scoped_ptr<base::Value> ToValue() const override;
+ APIPermission* Clone() const override;
+ APIPermission* Diff(const APIPermission* rhs) const override;
+ APIPermission* Union(const APIPermission* rhs) const override;
+ APIPermission* Intersect(const APIPermission* rhs) const override;
+ void Write(IPC::Message* m) const override;
+ bool Read(const IPC::Message* m, PickleIterator* iter) override;
+ void Log(std::string* log) const override;
private:
std::string setting_value_;
« no previous file with comments | « extensions/common/permissions/media_galleries_permission.h ('k') | extensions/common/permissions/socket_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698