Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 664843002: Web MIDI: distributes MIDIPort information asynchronously (Closed)

Created:
6 years, 2 months ago by Takashi Toyoshima
Modified:
6 years, 2 months ago
Reviewers:
palmer, yukawa, yhirano
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-ipc_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lifecycle
Project:
chromium
Visibility:
Public.

Description

Web MIDI: distributes MIDIPort information asynchronously MidiPortInfoList for input and output devices were accessible from MidiHost, and MidiHost distributed it via IPC on sending MidiMsg_SessionStarted. To update these device lists asynchronously and keep them consistent in all renderers, stop exposing them and invoke a client method, AddInputPort() or AddOutputPort() insteads. These client methods are called for all existing devices on opening a session at once. If MidiManager supports, these can be called for a device on each connection and disconnection. BUG=422333 TEST=media_unittests Committed: https://crrev.com/81a31130a4b43684454423203003bcc3fbe319f6 Cr-Commit-Position: refs/heads/master@{#300894}

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : unittests #

Patch Set 4 : [rebase] #

Patch Set 5 : typo on ipc #

Total comments: 1

Patch Set 6 : rebase #

Patch Set 7 : C++11 #

Total comments: 2

Patch Set 8 : [rebase] #

Patch Set 9 : review #8 #

Total comments: 4

Patch Set 10 : review #11 #

Patch Set 11 : speculative win build fix #

Patch Set 12 : . => -> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -54 lines) Patch
M content/browser/media/midi_host.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/media/midi_host.cc View 1 2 3 4 5 6 7 8 9 2 chunks +13 lines, -11 lines 0 comments Download
M content/common/media/midi_messages.h View 1 2 3 4 1 chunk +8 lines, -4 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -5 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 1 2 3 4 5 6 7 8 9 5 chunks +33 lines, -11 lines 0 comments Download
M media/midi/midi_manager.h View 1 2 3 4 5 6 7 8 9 4 chunks +17 lines, -14 lines 0 comments Download
M media/midi/midi_manager.cc View 1 2 3 4 5 6 4 chunks +23 lines, -4 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 2 3 4 5 4 chunks +15 lines, -2 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Takashi Toyoshima
PTAL once https://codereview.chromium.org/662853003/ is submitted.
6 years, 2 months ago (2014-10-18 18:44:30 UTC) #2
Takashi Toyoshima
https://codereview.chromium.org/664843002/diff/120001/content/renderer/media/midi_message_filter.cc File content/renderer/media/midi_message_filter.cc (right): https://codereview.chromium.org/664843002/diff/120001/content/renderer/media/midi_message_filter.cc#newcode209 content/renderer/media/midi_message_filter.cc:209: } Originally, I protect line 210:230 with the lock_ ...
6 years, 2 months ago (2014-10-20 18:31:13 UTC) #5
Takashi Toyoshima
palmer@chromium.org: Please review changes in midi_messages.h. This follows https://codereview.chromium.org/662853003/ that is almost finished as you've ...
6 years, 2 months ago (2014-10-22 12:20:48 UTC) #7
palmer
LGTM. https://codereview.chromium.org/664843002/diff/160001/content/renderer/media/midi_message_filter.h File content/renderer/media/midi_message_filter.h (right): https://codereview.chromium.org/664843002/diff/160001/content/renderer/media/midi_message_filter.h#newcode72 content/renderer/media/midi_message_filter.h:72: // Called on two cases. One is just ...
6 years, 2 months ago (2014-10-22 22:55:13 UTC) #8
Takashi Toyoshima
Thanks Palmer, Documentation cleanup is very helpful :) Yutaka: PTAL as a midi owners. https://codereview.chromium.org/664843002/diff/160001/content/renderer/media/midi_message_filter.h ...
6 years, 2 months ago (2014-10-23 07:37:08 UTC) #9
yhirano
lgtm https://codereview.chromium.org/664843002/diff/200001/content/browser/media/midi_host.cc File content/browser/media/midi_host.cc (right): https://codereview.chromium.org/664843002/diff/200001/content/browser/media/midi_host.cc#newcode140 content/browser/media/midi_host.cc:140: received_messages_queues_.push_back(NULL); You can use nullptr. https://codereview.chromium.org/664843002/diff/200001/media/midi/midi_manager.h File media/midi/midi_manager.h ...
6 years, 2 months ago (2014-10-23 08:24:13 UTC) #10
Takashi Toyoshima
https://codereview.chromium.org/664843002/diff/200001/content/browser/media/midi_host.cc File content/browser/media/midi_host.cc (right): https://codereview.chromium.org/664843002/diff/200001/content/browser/media/midi_host.cc#newcode140 content/browser/media/midi_host.cc:140: received_messages_queues_.push_back(NULL); On 2014/10/23 08:24:13, yhirano wrote: > You can ...
6 years, 2 months ago (2014-10-23 09:33:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664843002/220001
6 years, 2 months ago (2014-10-23 09:35:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/22154)
6 years, 2 months ago (2014-10-23 10:09:20 UTC) #15
Takashi Toyoshima
+yukawa@ (TBR on win build fix)
6 years, 2 months ago (2014-10-23 11:09:29 UTC) #17
yukawa
LGTM for media/midi/midi_manager_win.cc
6 years, 2 months ago (2014-10-23 11:13:42 UTC) #18
Takashi Toyoshima
Thanks. If trybot result looks fine, I'll kick CQ again:)
6 years, 2 months ago (2014-10-23 11:16:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664843002/260001
6 years, 2 months ago (2014-10-23 14:56:57 UTC) #21
commit-bot: I haz the power
Committed patchset #12 (id:260001)
6 years, 2 months ago (2014-10-23 16:05:12 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 16:05:58 UTC) #23
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/81a31130a4b43684454423203003bcc3fbe319f6
Cr-Commit-Position: refs/heads/master@{#300894}

Powered by Google App Engine
This is Rietveld 408576698