Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 662233002: Web MIDI: make MidiManagerMac notify device connections (Closed)

Created:
6 years, 2 months ago by Takashi Toyoshima
Modified:
5 years, 10 months ago
Reviewers:
palmer, yhirano
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-ipc_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: make MidiManagerMac notify device connection status To handle device connection status, MidiManager and MidiMessageFilter hold all devices as a list. These lists are modified by event notifications that are delivered asynchronously. They do not remove disconnected devices, but just mark as disconnected. This is useful when JavaScript has a reference to a device that got disconnected. The reference can be availalbe if the device gets connected again. BUG=422333 TEST=media_unittests Committed: https://crrev.com/40405201282bde7546763d2402d31104cc991ba0 Cr-Commit-Position: refs/heads/master@{#317000}

Patch Set 1 : #

Patch Set 2 : rebase + cleanup #

Total comments: 13

Patch Set 3 : use enum for MidiPortState #

Total comments: 2

Patch Set 4 : std::find #

Patch Set 5 : i - begin #

Total comments: 4

Patch Set 6 : it->second #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -23 lines) Patch
M content/browser/media/midi_host.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/media/midi_host.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/media/midi_messages.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 1 2 3 chunks +34 lines, -0 lines 0 comments Download
M media/midi/midi_manager.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M media/midi/midi_manager.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M media/midi/midi_manager_mac.h View 1 2 chunks +12 lines, -7 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 1 2 3 4 5 5 chunks +61 lines, -4 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M media/midi/midi_port_info.h View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M media/midi/midi_port_info.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
Takashi Toyoshima
PTAL once https://codereview.chromium.org/664843002/ is submitted
6 years, 2 months ago (2014-10-18 18:54:18 UTC) #6
Takashi Toyoshima
palmer@chromium.org: Please review changes in midi_messages.h yhirano@chromium.org: PTAL https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_port_info.h File media/midi/midi_port_info.h (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_port_info.h#newcode22 media/midi/midi_port_info.h:22: bool ...
6 years, 2 months ago (2014-10-23 11:13:02 UTC) #9
yhirano
https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_alsa.cc File media/midi/midi_manager_alsa.cc (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_alsa.cc#newcode255 media/midi/midi_manager_alsa.cc:255: const bool connected = trie; true https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc ...
6 years, 2 months ago (2014-10-24 03:30:08 UTC) #10
palmer
IPC security LGTM, once you change to std::find. https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc#newcode231 media/midi/midi_manager_mac.cc:231: for ...
6 years, 2 months ago (2014-10-24 19:07:14 UTC) #11
Takashi Toyoshima
W3C spec updates require updating this change too. I'll ping again once this is ready ...
6 years, 1 month ago (2014-10-27 04:31:29 UTC) #12
Takashi Toyoshima
I will resume this patch. https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_alsa.cc File media/midi/midi_manager_alsa.cc (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_alsa.cc#newcode255 media/midi/midi_manager_alsa.cc:255: const bool connected = ...
5 years, 10 months ago (2015-02-17 17:10:38 UTC) #13
yhirano
https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc#newcode231 media/midi/midi_manager_mac.cc:231: for (uint32 i = 0; i < destinations_.size(); ++i) ...
5 years, 10 months ago (2015-02-18 03:21:25 UTC) #14
Takashi Toyoshima
thanks. ptal patch set 5. https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc (right): https://codereview.chromium.org/662233002/diff/120001/media/midi/midi_manager_mac.cc#newcode231 media/midi/midi_manager_mac.cc:231: for (uint32 i = ...
5 years, 10 months ago (2015-02-18 04:43:13 UTC) #15
Takashi Toyoshima
FYI, pull request on MidiPortState was merged into the spec now.
5 years, 10 months ago (2015-02-18 14:06:35 UTC) #16
yhirano
lgtm https://codereview.chromium.org/662233002/diff/180001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc (right): https://codereview.chromium.org/662233002/diff/180001/media/midi/midi_manager_mac.cc#newcode227 media/midi/midi_manager_mac.cc:227: uint32 index = source_map_[endpoint]; s/source_map_[endpoint]/it->second/ https://codereview.chromium.org/662233002/diff/180001/media/midi/midi_manager_mac.cc#newcode248 media/midi/midi_manager_mac.cc:248: uint32 ...
5 years, 10 months ago (2015-02-19 02:40:46 UTC) #17
Takashi Toyoshima
thanks https://codereview.chromium.org/662233002/diff/180001/media/midi/midi_manager_mac.cc File media/midi/midi_manager_mac.cc (right): https://codereview.chromium.org/662233002/diff/180001/media/midi/midi_manager_mac.cc#newcode227 media/midi/midi_manager_mac.cc:227: uint32 index = source_map_[endpoint]; On 2015/02/19 02:40:45, yhirano ...
5 years, 10 months ago (2015-02-19 02:58:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662233002/200001
5 years, 10 months ago (2015-02-19 03:01:18 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/34219)
5 years, 10 months ago (2015-02-19 04:10:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662233002/200001
5 years, 10 months ago (2015-02-19 06:28:39 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:200001)
5 years, 10 months ago (2015-02-19 07:28:19 UTC) #26
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 07:28:47 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/40405201282bde7546763d2402d31104cc991ba0
Cr-Commit-Position: refs/heads/master@{#317000}

Powered by Google App Engine
This is Rietveld 408576698