Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664443002: Support chrome app frame colors on ChromeOS. (Closed)

Created:
6 years, 2 months ago by benwells
Modified:
6 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support chrome app frame colors on ChromeOS. Adds support for colored frames for chrome apps which use the chrome.app.window.create API to create windows. BUG=371642 Committed: https://crrev.com/e30f8c16363cf605691e6605131b8cccabba9834 Cr-Commit-Position: refs/heads/master@{#300070}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M ash/frame/custom_frame_view_ash.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M ash/frame/default_header_painter.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/frame/default_header_painter.cc View 1 2 5 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
benwells
6 years, 2 months ago (2014-10-16 22:40:36 UTC) #2
pkotwicz
LGTM
6 years, 2 months ago (2014-10-16 23:16:43 UTC) #3
pkotwicz
https://codereview.chromium.org/664443002/diff/1/ash/frame/default_header_painter.cc File ash/frame/default_header_painter.cc (right): https://codereview.chromium.org/664443002/diff/1/ash/frame/default_header_painter.cc#newcode38 ash/frame/default_header_painter.cc:38: // The color of the frame. Nit: The default ...
6 years, 2 months ago (2014-10-16 23:21:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664443002/40001
6 years, 2 months ago (2014-10-17 04:46:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-17 06:19:54 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 06:20:38 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e30f8c16363cf605691e6605131b8cccabba9834
Cr-Commit-Position: refs/heads/master@{#300070}

Powered by Google App Engine
This is Rietveld 408576698