Convert manually triggered try runs to use bots without _swarming prefix.

Convert manually triggered try runs to use bots without _swarming prefix.

BUG=425813
R=phajdan.jr@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a2226a6c8159d2487733b22e31ee536e615296f8

[jam, 2014-10-22 04:53:36]

jam@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[danakj, 2014-10-22 14:22:40]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-10-22 14:22:41]

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT.py
File ui/compositor/PRESUBMIT.py (right):

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT....
ui/compositor/PRESUBMIT.py:14: 'linux_chromium_chromeos_rel':
set(['defaulttests']),
this is in the default set of bots now in src/PRESUBMIT.py right? so we can just
remove this file?

[Paweł Hajdan Jr., 2014-10-22 15:15:23]

This looks good, please make sure all affected tryserver masters are restarted
with the change linked in the bug so it takes effect.

https://codereview.chromium.org/664413006/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.chromium.org/664413006/diff/20001/PRESUBMIT.py#oldcode1609
PRESUBMIT.py:1609: 'linux_chromium_chromeos_rel_swarming': ['defaulttests'],
Could you keep the _swarming lines there and instead add non-swarming ones? This
reduces likelihood of a crash on missing key.

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT.py
File ui/compositor/PRESUBMIT.py (right):

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT....
ui/compositor/PRESUBMIT.py:14: 'linux_chromium_chromeos_rel':
set(['defaulttests']),
On 2014/10/22 14:22:41, danakj wrote:
> this is in the default set of bots now in src/PRESUBMIT.py right? so we can
just
> remove this file?

+1, could you also apply it to other files as well?

[jam, 2014-10-22 16:00:59]

https://codereview.chromium.org/664413006/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.chromium.org/664413006/diff/20001/PRESUBMIT.py#oldcode1609
PRESUBMIT.py:1609: 'linux_chromium_chromeos_rel_swarming': ['defaulttests'],
On 2014/10/22 15:15:23, Paweł Hajdan Jr. wrote:
> Could you keep the _swarming lines there and instead add non-swarming ones?
This
> reduces likelihood of a crash on missing key.

no i dont see why we should to that. if a presubmit file has the old value it
should be fixed. i've found all of them.

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT.py
File ui/compositor/PRESUBMIT.py (right):

https://codereview.chromium.org/664413006/diff/20001/ui/compositor/PRESUBMIT....
ui/compositor/PRESUBMIT.py:14: 'linux_chromium_chromeos_rel':
set(['defaulttests']),
On 2014/10/22 15:15:23, Paweł Hajdan Jr. wrote:
> On 2014/10/22 14:22:41, danakj wrote:
> > this is in the default set of bots now in src/PRESUBMIT.py right? so we can
> just
> > remove this file?
> 
> +1, could you also apply it to other files as well?

no, let's do that cleanup separately. this is strictly about removing the
_swarming bots. feel free to do cleanup in a followup

[Paweł Hajdan Jr., 2014-10-22 16:47:20]

Okay, LGTM.

[commit-bot: I haz the power, 2014-10-22 16:51:26]

Patchset 2 (id:??) landed as
https://crrev.com/a2226a6c8159d2487733b22e31ee536e615296f8
Cr-Commit-Position: refs/heads/master@{#300691}

[jam, 2014-10-22 16:51:35]

Committed patchset #2 (id:20001) manually as
a2226a6c8159d2487733b22e31ee536e615296f8 (presubmit successful).