ui/compositor/PRESUBMIT.py - Issue 664413006: Convert manually triggered try runs to use bots without _swarming prefix.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/compositor/PRESUBMIT.py

Issue 664413006: Convert manually triggered try runs to use bots without _swarming prefix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Chromium presubmit script for src/ui/compositor/.	5 """Chromium presubmit script for src/ui/compositor/.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details on the presubmit API built into gcl.	8 for more details on the presubmit API built into gcl.

9 """	9 """

10	10

11 def GetPreferredTryMasters(project, change):	11 def GetPreferredTryMasters(project, change):

12 return {	12 return {

13 'tryserver.chromium.linux': {	13 'tryserver.chromium.linux': {

14 'linux_chromium_chromeos_rel_swarming': set(['defaulttests']),	14 'linux_chromium_chromeos_rel': set(['defaulttests']),
	danakj 2014/10/22 14:22:41 this is in the default set of bots now in src/PRES this is in the default set of bots now in src/PRESUBMIT.py right? so we can just remove this file? Paweł Hajdan Jr. 2014/10/22 15:15:23 +1, could you also apply it to other files as well Show quoted text On 2014/10/22 14:22:41, danakj wrote: > this is in the default set of bots now in src/PRESUBMIT.py right? so we can just > remove this file? +1, could you also apply it to other files as well? jam 2014/10/22 16:00:59 no, let's do that cleanup separately. this is stri Show quoted text On 2014/10/22 15:15:23, Paweł Hajdan Jr. wrote: > On 2014/10/22 14:22:41, danakj wrote: > > this is in the default set of bots now in src/PRESUBMIT.py right? so we can > just > > remove this file? > > +1, could you also apply it to other files as well? no, let's do that cleanup separately. this is strictly about removing the _swarming bots. feel free to do cleanup in a followup
15 }	15 }

16 }	16 }

OLD	NEW

« PRESUBMIT.py ('K') | « sync/PRESUBMIT.py ('k') | ui/events/PRESUBMIT.py » ('j') | no next file with comments »