Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: PRESUBMIT.py

Issue 664413006: Convert manually triggered try runs to use bots without _swarming prefix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | ui/compositor/PRESUBMIT.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1588 matching lines...) Expand 10 before | Expand all | Expand 10 after
1599 'ui_base_unittests', 1599 'ui_base_unittests',
1600 'ui_unittests', 1600 'ui_unittests',
1601 ], 1601 ],
1602 'ios_rel_device': ['compile'], 1602 'ios_rel_device': ['compile'],
1603 'ios_rel_device_ninja': ['compile'], 1603 'ios_rel_device_ninja': ['compile'],
1604 'mac_asan': ['compile'], 1604 'mac_asan': ['compile'],
1605 #TODO(stip): Change the name of this builder to reflect that it's release. 1605 #TODO(stip): Change the name of this builder to reflect that it's release.
1606 'linux_gtk': standard_tests, 1606 'linux_gtk': standard_tests,
1607 'linux_chromeos_asan': ['compile'], 1607 'linux_chromeos_asan': ['compile'],
1608 'linux_chromium_chromeos_clang_dbg': ['defaulttests'], 1608 'linux_chromium_chromeos_clang_dbg': ['defaulttests'],
1609 'linux_chromium_chromeos_rel_swarming': ['defaulttests'], 1609 'linux_chromium_chromeos_rel': ['defaulttests'],
Paweł Hajdan Jr. 2014/10/22 15:15:23 Could you keep the _swarming lines there and inste
jam 2014/10/22 16:00:59 no i dont see why we should to that. if a presubmi
1610 'linux_chromium_compile_dbg': ['defaulttests'], 1610 'linux_chromium_compile_dbg': ['defaulttests'],
1611 'linux_chromium_gn_dbg': ['compile'], 1611 'linux_chromium_gn_dbg': ['compile'],
1612 'linux_chromium_gn_rel': ['defaulttests'], 1612 'linux_chromium_gn_rel': ['defaulttests'],
1613 'linux_chromium_rel_swarming': ['defaulttests'], 1613 'linux_chromium_rel': ['defaulttests'],
1614 'linux_chromium_clang_dbg': ['defaulttests'], 1614 'linux_chromium_clang_dbg': ['defaulttests'],
1615 'linux_gpu': ['defaulttests'], 1615 'linux_gpu': ['defaulttests'],
1616 'linux_nacl_sdk_build': ['compile'], 1616 'linux_nacl_sdk_build': ['compile'],
1617 'mac_chromium_compile_dbg': ['defaulttests'], 1617 'mac_chromium_compile_dbg': ['defaulttests'],
1618 'mac_chromium_rel_swarming': ['defaulttests'], 1618 'mac_chromium_rel': ['defaulttests'],
1619 'mac_gpu': ['defaulttests'], 1619 'mac_gpu': ['defaulttests'],
1620 'mac_nacl_sdk_build': ['compile'], 1620 'mac_nacl_sdk_build': ['compile'],
1621 'win_chromium_compile_dbg': ['defaulttests'], 1621 'win_chromium_compile_dbg': ['defaulttests'],
1622 'win_chromium_dbg': ['defaulttests'], 1622 'win_chromium_dbg': ['defaulttests'],
1623 'win_chromium_rel_swarming': ['defaulttests'], 1623 'win_chromium_rel': ['defaulttests'],
1624 'win_chromium_x64_rel_swarming': ['defaulttests'], 1624 'win_chromium_x64_rel': ['defaulttests'],
1625 'win_gpu': ['defaulttests'], 1625 'win_gpu': ['defaulttests'],
1626 'win_nacl_sdk_build': ['compile'], 1626 'win_nacl_sdk_build': ['compile'],
1627 'win8_chromium_rel': ['defaulttests'], 1627 'win8_chromium_rel': ['defaulttests'],
1628 } 1628 }
1629 1629
1630 if bots: 1630 if bots:
1631 filtered_builders_and_tests = dict((bot, set(builders_and_tests[bot])) 1631 filtered_builders_and_tests = dict((bot, set(builders_and_tests[bot]))
1632 for bot in bots) 1632 for bot in bots)
1633 else: 1633 else:
1634 filtered_builders_and_tests = dict( 1634 filtered_builders_and_tests = dict(
(...skipping 29 matching lines...) Expand all
1664 def GetPreferredTryMasters(project, change): 1664 def GetPreferredTryMasters(project, change):
1665 import re 1665 import re
1666 files = change.LocalPaths() 1666 files = change.LocalPaths()
1667 1667
1668 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): 1668 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files):
1669 return {} 1669 return {}
1670 1670
1671 if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files): 1671 if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files):
1672 return GetDefaultTryConfigs([ 1672 return GetDefaultTryConfigs([
1673 'mac_chromium_compile_dbg', 1673 'mac_chromium_compile_dbg',
1674 'mac_chromium_rel_swarming', 1674 'mac_chromium_rel',
1675 ]) 1675 ])
1676 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1676 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1677 return GetDefaultTryConfigs([ 1677 return GetDefaultTryConfigs([
1678 'win_chromium_dbg', 1678 'win_chromium_dbg',
1679 'win_chromium_rel_swarming', 1679 'win_chromium_rel',
1680 'win8_chromium_rel', 1680 'win8_chromium_rel',
1681 ]) 1681 ])
1682 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): 1682 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files):
1683 return GetDefaultTryConfigs([ 1683 return GetDefaultTryConfigs([
1684 'android_aosp', 1684 'android_aosp',
1685 'android_clang_dbg', 1685 'android_clang_dbg',
1686 'android_dbg_tests_recipe', 1686 'android_dbg_tests_recipe',
1687 ]) 1687 ])
1688 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): 1688 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files):
1689 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1689 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1690 1690
1691 builders = [ 1691 builders = [
1692 'android_arm64_dbg_recipe', 1692 'android_arm64_dbg_recipe',
1693 'android_chromium_gn_compile_rel', 1693 'android_chromium_gn_compile_rel',
1694 'android_chromium_gn_compile_dbg', 1694 'android_chromium_gn_compile_dbg',
1695 'android_clang_dbg', 1695 'android_clang_dbg',
1696 'android_clang_dbg_recipe', 1696 'android_clang_dbg_recipe',
1697 'android_dbg_tests_recipe', 1697 'android_dbg_tests_recipe',
1698 'ios_dbg_simulator', 1698 'ios_dbg_simulator',
1699 'ios_rel_device', 1699 'ios_rel_device',
1700 'ios_rel_device_ninja', 1700 'ios_rel_device_ninja',
1701 'linux_chromium_chromeos_rel_swarming', 1701 'linux_chromium_chromeos_rel',
1702 'linux_chromium_clang_dbg', 1702 'linux_chromium_clang_dbg',
1703 'linux_chromium_gn_dbg', 1703 'linux_chromium_gn_dbg',
1704 'linux_chromium_gn_rel', 1704 'linux_chromium_gn_rel',
1705 'linux_chromium_rel_swarming', 1705 'linux_chromium_rel',
1706 'linux_gpu', 1706 'linux_gpu',
1707 'mac_chromium_compile_dbg', 1707 'mac_chromium_compile_dbg',
1708 'mac_chromium_rel_swarming', 1708 'mac_chromium_rel',
1709 'mac_gpu', 1709 'mac_gpu',
1710 'win_chromium_compile_dbg', 1710 'win_chromium_compile_dbg',
1711 'win_chromium_rel_swarming', 1711 'win_chromium_rel',
1712 'win_chromium_x64_rel_swarming', 1712 'win_chromium_x64_rel',
1713 'win_gpu', 1713 'win_gpu',
1714 'win8_chromium_rel', 1714 'win8_chromium_rel',
1715 ] 1715 ]
1716 1716
1717 # Match things like path/aura/file.cc and path/file_aura.cc. 1717 # Match things like path/aura/file.cc and path/file_aura.cc.
1718 # Same for chromeos. 1718 # Same for chromeos.
1719 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): 1719 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
1720 builders.extend([ 1720 builders.extend([
1721 'linux_chromeos_asan', 1721 'linux_chromeos_asan',
1722 'linux_chromium_chromeos_clang_dbg' 1722 'linux_chromium_chromeos_clang_dbg'
1723 ]) 1723 ])
1724 1724
1725 # If there are gyp changes to base, build, or chromeos, run a full cros build 1725 # If there are gyp changes to base, build, or chromeos, run a full cros build
1726 # in addition to the shorter linux_chromeos build. Changes to high level gyp 1726 # in addition to the shorter linux_chromeos build. Changes to high level gyp
1727 # files have a much higher chance of breaking the cros build, which is 1727 # files have a much higher chance of breaking the cros build, which is
1728 # differnt from the linux_chromeos build that most chrome developers test 1728 # differnt from the linux_chromeos build that most chrome developers test
1729 # with. 1729 # with.
1730 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): 1730 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files):
1731 builders.extend(['cros_x86']) 1731 builders.extend(['cros_x86'])
1732 1732
1733 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1733 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1734 # unless they're .gyp(i) files as changes to those files can break the gyp 1734 # unless they're .gyp(i) files as changes to those files can break the gyp
1735 # step on that bot. 1735 # step on that bot.
1736 if (not all(re.search('^chrome', f) for f in files) or 1736 if (not all(re.search('^chrome', f) for f in files) or
1737 any(re.search('\.gypi?$', f) for f in files)): 1737 any(re.search('\.gypi?$', f) for f in files)):
1738 builders.extend(['android_aosp']) 1738 builders.extend(['android_aosp'])
1739 1739
1740 return GetDefaultTryConfigs(builders) 1740 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | ui/compositor/PRESUBMIT.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698