LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php - Issue 663723002: [ServiceWorker] Handle ServiceWorker script fetch error code correctly. [blink]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding-with-flush.php

Issue 663723002: [ServiceWorker] Handle ServiceWorker script fetch error code correctly. [blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use promise_test and assert_promise_rejects Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?php

	2 header('Content-Type:application/javascript');

	3 header("Transfer-encoding: chunked");

	4 flush();

	5 sleep(1);
	falken 2014/10/17 06:39:17 why is this sleep needed? does it block test compl why is this sleep needed? does it block test completion? can it be smaller? horo 2014/10/17 06:53:22 Without this sleep, net_request_->Read() in Servic Show quoted text On 2014/10/17 06:39:17, falken wrote: > why is this sleep needed? does it block test completion? can it be smaller? Without this sleep, net_request_->Read() in ServiceWorkerWriteToCacheJob::ReadNetDat() returns true and get the data synchronously. I want to test the asynchronous read operation and execute the ServiceWorkerWriteToCacheJob::OnReadCompleted() method. If the sleep time is smaller, the read operation may be done synchronously.
	6 echo "XX\r\n\r\n";

	7 ?>

OLD	NEW

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/invalid-chunked-encoding.php ('k') | no next file » | no next file with comments »