Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2090)

Unified Diff: public/web/WebViewClient.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated unittest to use different urls and destructor to register same url again Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« public/web/WebInputEvent.h ('K') | « public/web/WebInputEvent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index fa39080f10f3357a060fe897c946eee91b29d73e..494ad2af7c40a5908709adfd63388136b5a88d37 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -134,6 +134,13 @@ public:
// indicating that the default action should be suppressed.
virtual bool handleCurrentKeyboardEvent() { return false; }
+ // This method converts from the supplied enum value for the key
Rick Byers 2015/01/23 20:38:30 I'm OK using an opaque 'int' here (there are some
Habib Virji 2015/01/26 11:32:35 Done.
+ // to the embedder's DOM |code| string.
+ virtual WebString domCodeStringFromEnum(int domCode) { return ""; }
Rick Byers 2015/01/23 20:38:30 Again, let's be precise about the "enum" in questi
Wez 2015/01/23 20:59:49 IMO "DOM code string" and "DOM code enum" make mos
Habib Virji 2015/01/26 11:32:35 Done.
+
+ // This method converts from the suppled DOM |code| string to the
+ // embedder's enum value for the key.
+ virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
// Dialogs -------------------------------------------------------------
« public/web/WebInputEvent.h ('K') | « public/web/WebInputEvent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698