Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

public/web/WebViewClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 116 matching lines @@
 
     // This method is called in response to WebView's handleInputEvent()
     // when the default action for the current keyboard event is not
     // suppressed by the page, to give the embedder a chance to handle
     // the keyboard event specially.
     //
     // Returns true if the keyboard event was handled by the embedder,
     // indicating that the default action should be suppressed.
     virtual bool handleCurrentKeyboardEvent() { return false; }
 
+    // This method converts from the supplied enum value for the key

[Rick Byers, 2015/01/23 20:38:30]

I'm OK using an opaque 'int' here (there are some other examples in the blink
Web API), but only if we're as precise as possible in the comments about where
the meaning of this value is defined.

Also, for both APIs, please define what should happen with unknown/invalid
input.

[Habib Virji, 2015/01/26 11:32:35]

Done.

+    // to the embedder's DOM |code| string.
+    virtual WebString domCodeStringFromEnum(int domCode) { return ""; }

[Rick Byers, 2015/01/23 20:38:30]

Again, let's be precise about the "enum" in question here.  What's the best term
for consistency with chromium - "DOM code value" perhaps?  

Perhaps domCodeStringFromDomCodeValue?

[Wez, 2015/01/23 20:59:49]

IMO "DOM code string" and "DOM code enum" make most sense; "DOM code value"
sounds ambiguous as to whether it means the string or the opaque Chromium enum.

kpschoedel@, does that make sense to you?

[Habib Virji, 2015/01/26 11:32:35]

Done.

+
+    // This method converts from the suppled DOM |code| string to the
+    // embedder's enum value for the key.
+    virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
 
     // Dialogs -------------------------------------------------------------
 
     // This method returns immediately after showing the dialog. When the
     // dialog is closed, it should call the WebFileChooserCompletion to
     // pass the results of the dialog. Returns false if
     // WebFileChooseCompletion will never be called.
     virtual bool runFileChooser(const WebFileChooserParams&,
                                 WebFileChooserCompletion*) { return false; }
 
@@ skipping 146 matching lines @@
     // Informs the browser that the draggable regions have been updated.
     virtual void draggableRegionsChanged() { }
 
 protected:
     ~WebViewClient() { }
 };
 
 } // namespace blink
 
 #endif