public/web/WebInputEvent.h - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebInputEvent.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated unittest to use different urls and destructor to register same url again Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebInputEvent.h

diff --git a/public/web/WebInputEvent.h b/public/web/WebInputEvent.h

index 74ad0b11100e3bb5eb641329501fd534e70b10a6..2d43127617b0ee56a8cd2b22154535e272d85dcf 100644

--- a/public/web/WebInputEvent.h

+++ b/public/web/WebInputEvent.h

@@ -237,6 +237,9 @@ public:

// doesn't hurt to have this one around.

int nativeKeyCode;

+ // The enum code value of the key pressed as passed by the embedder.

Rick Byers 2015/01/23 20:38:30 Please add a comment saying where exactly the enum

Rick Byers 2015/01/23 20:38:30 nit: maybe "DOM code enum value" just to be precis

Habib Virji 2015/01/26 11:32:35 Done.

+ int domCode;

// This identifies whether this event was tagged by the system as being

// a "system key" event (see

// http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx for

« LayoutTests/fast/events/keyboardevent-code.html ('K') | « Source/web/tests/WebPluginContainerTest.cpp ('k') | public/web/WebViewClient.h » ('j') | public/web/WebViewClient.h » ('J')