Source/web/RemoteFrameClientImpl.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/RemoteFrameClientImpl.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added new embedder API and code review comments update Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/RemoteFrameClientImpl.cpp

diff --git a/Source/web/RemoteFrameClientImpl.cpp b/Source/web/RemoteFrameClientImpl.cpp

index b19e9f06f8d16b7ca0701afea18e3090d8669729..8bfca7d060409c7ac78fb6271a7d72b89e2862a4 100644

--- a/Source/web/RemoteFrameClientImpl.cpp

+++ b/Source/web/RemoteFrameClientImpl.cpp

@@ -110,7 +110,7 @@ void RemoteFrameClientImpl::forwardInputEvent(Event* event)

// FIXME: Add a check for out-of-process iframes enabled.

OwnPtr<WebInputEvent> webEvent;

if (event->isKeyboardEvent())

- webEvent = adoptPtr(new WebKeyboardEventBuilder(*static_cast<KeyboardEvent*>(event)));

+ webEvent = adoptPtr(new WebKeyboardEventBuilder(m_webFrame->frame()->view(), *static_cast<KeyboardEvent*>(event)));

else if (event->isMouseEvent())

webEvent = adoptPtr(new WebMouseEventBuilder(m_webFrame->frame()->view(), toCoreFrame(m_webFrame)->ownerRenderer(), *static_cast<MouseEvent*>(event)));

else if (event->isWheelEvent())

« Source/core/events/KeyboardEvent.idl ('K') | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | Source/web/WebInputEvent.cpp » ('J')