Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added new embedder API and code review comments update Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index f3adc6a24a0f9d60ed9519d4865c39ce61e6b09e..f43811b319a8a9ca924388a180781e334cd2b747 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -356,7 +356,7 @@ bool WebDevToolsAgentImpl::handleInputEvent(Page* page, const WebInputEvent& inp
return ic->handleTouchEvent(toLocalFrame(page->mainFrame()), touchEvent);
}
if (WebInputEvent::isKeyboardEventType(inputEvent.type)) {
- PlatformKeyboardEvent keyboardEvent = PlatformKeyboardEventBuilder(static_cast<const WebKeyboardEvent&>(inputEvent));
+ PlatformKeyboardEvent keyboardEvent = PlatformKeyboardEventBuilder(page->deprecatedLocalMainFrame()->view(), static_cast<const WebKeyboardEvent&>(inputEvent));
return ic->handleKeyboardEvent(page->deprecatedLocalMainFrame(), keyboardEvent);
}
return false;
@@ -502,7 +502,7 @@ void WebDevToolsAgentImpl::dispatchKeyEvent(const PlatformKeyboardEvent& event)
m_webViewImpl->setFocus(true);
m_generatingEvent = true;
- WebKeyboardEvent webEvent = WebKeyboardEventBuilder(event);
+ WebKeyboardEvent webEvent = WebKeyboardEventBuilder(m_webViewImpl->mainFrameImpl()->frameView(), event);
if (!webEvent.keyIdentifier[0] && webEvent.type != WebInputEvent::Char)
webEvent.setKeyIdentifierFromWindowsKeyCode();
m_webViewImpl->handleInputEvent(webEvent);

Powered by Google App Engine
This is Rietveld 408576698