Source/web/ChromeClientImpl.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added new embedder API and code review comments update Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 53816ce6c853c965aecf9b9e6c981b5cb51117d9..ff808e482cdc9aaf56b640783f6535852536bcd5 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -835,7 +835,7 @@ void ChromeClientImpl::handleKeyboardEventOnTextField(HTMLInputElement& inputEle

{

WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(inputElement.document().frame());

if (webframe->autofillClient())

- webframe->autofillClient()->textFieldDidReceiveKeyDown(WebInputElement(&inputElement), WebKeyboardEventBuilder(event));

+ webframe->autofillClient()->textFieldDidReceiveKeyDown(WebInputElement(&inputElement), WebKeyboardEventBuilder(webframe->frameView(), event));

}

void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element)

« Source/core/events/KeyboardEvent.idl ('K') | « Source/platform/PlatformKeyboardEvent.h ('k') | Source/web/RemoteFrameClientImpl.cpp » ('j') | Source/web/WebInputEvent.cpp » ('J')