Source/web/tests/WebPluginContainerTest.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebPluginContainerTest.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated to use domCode instead of native domCode Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebPluginContainerTest.cpp

diff --git a/Source/web/tests/WebPluginContainerTest.cpp b/Source/web/tests/WebPluginContainerTest.cpp

index e8751b9bf43fc5264911c74d0a2abca02f8bd935..445e86486efa01cdf2a558ded6ce86cb283af467 100644

--- a/Source/web/tests/WebPluginContainerTest.cpp

+++ b/Source/web/tests/WebPluginContainerTest.cpp

@@ -199,7 +199,7 @@ TEST_F(WebPluginContainerTest, CopyInsertKeyboardEventsTest)

#if OS(MACOSX)

modifierKey = PlatformEvent::MetaKey;

#endif

- PlatformKeyboardEvent platformKeyboardEventC(PlatformEvent::RawKeyDown, "", "", "67", 67, 0, false, false, false, modifierKey, 0.0);

+ PlatformKeyboardEvent platformKeyboardEventC(PlatformEvent::RawKeyDown, "", "", "67", 67, 67, 0, false, false, false, modifierKey, 0.0);

Wez 2015/01/08 01:14:48 Better to supply a properly "dummy" value for domC

Habib Virji 2015/01/12 15:34:17 Done.

RefPtrWillBeRawPtr<KeyboardEvent> keyEventC = KeyboardEvent::create(platformKeyboardEventC, 0);

((WebPluginContainerImpl*)(pluginContainerOneElement.pluginContainer()))->handleEvent(keyEventC.get());

EXPECT_EQ(WebString("x"), Platform::current()->clipboard()->readPlainText(WebClipboard::Buffer()));

@@ -208,7 +208,7 @@ TEST_F(WebPluginContainerTest, CopyInsertKeyboardEventsTest)

Platform::current()->clipboard()->writePlainText(WebString(""));

EXPECT_EQ(WebString(""), Platform::current()->clipboard()->readPlainText(WebClipboard::Buffer()));

- PlatformKeyboardEvent platformKeyboardEventInsert(PlatformEvent::RawKeyDown, "", "", "45", 45, 0, false, false, false, modifierKey, 0.0);

+ PlatformKeyboardEvent platformKeyboardEventInsert(PlatformEvent::RawKeyDown, "", "", "45", 45, 45, 0, false, false, false, modifierKey, 0.0);

Wez 2015/01/08 01:14:48 Here too.

Habib Virji 2015/01/12 15:34:17 Done.

RefPtrWillBeRawPtr<KeyboardEvent> keyEventInsert = KeyboardEvent::create(platformKeyboardEventInsert, 0);

((WebPluginContainerImpl*)(pluginContainerOneElement.pluginContainer()))->handleEvent(keyEventInsert.get());

EXPECT_EQ(WebString("x"), Platform::current()->clipboard()->readPlainText(WebClipboard::Buffer()));

« Source/web/WebViewImpl.cpp ('K') | « Source/web/tests/WebInputEventConversionTest.cpp ('k') | public/web/WebInputEvent.h » ('j') | public/web/WebViewClient.h » ('J')