public/web/WebViewClient.h - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebViewClient.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated to use domCode instead of native domCode Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebViewClient.h

diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h

index fa39080f10f3357a060fe897c946eee91b29d73e..b5bc7c2c98006a0cb3b1e4b559887e98532e723a 100644

--- a/public/web/WebViewClient.h

+++ b/public/web/WebViewClient.h

@@ -134,6 +134,9 @@ public:

// indicating that the default action should be suppressed.

virtual bool handleCurrentKeyboardEvent() { return false; }

+ // This method converts from the embedded-supplied domCode to

+ // the string value of the domCode

+ virtual const char* keyboardDOMCodeValue(long domCode) { return ""; }

Wez 2015/01/08 01:14:48 Suggest domCodeStringFromEnum() or something along

Habib Virji 2015/01/12 15:34:17 Done.

// Dialogs -------------------------------------------------------------

« Source/web/tests/WebPluginContainerTest.cpp ('K') | « public/web/WebInputEvent.h ('k') | no next file » | no next file with comments »