Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/WebViewImpl.cpp

Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 5e21123d026f58b4ec1f0cfb3f5fde7051ac52ba..e7b70caace8ea4eb514657276a57b31ee97648bd 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -963,6 +963,7 @@ bool WebViewImpl::handleKeyEvent(const WebKeyboardEvent& event)
     LocalFrame* frame = toLocalFrame(focusedFrame.get());
 
     PlatformKeyboardEventBuilder evt(event);
+    evt.setKeyboardEventDOMCodeValue(m_client->keyboardDOMCodeValue(evt.domCode()));

[Wez, 2015/01/08 01:14:48]

It reads very oddly to be passing evt.domCode() into the conversion routine;
really what you're passing is the event.domCode value, I think.

Do we need to do the conversion from numeric value to code here, or could we
defer it until we need to convert from PlatformKeyboardEvent to DOM
KeyboardEvent?

[Habib Virji, 2015/01/12 15:34:17]

I have deferred it, please have a look. It now happens in
WebInputEventConversion.

[Wez, 2015/01/17 02:35:10]

SGTM - please check w/ e.g. rbyers@ that the frameView() references throughout
this patch are correct - I'm not sure whether mainFrameImpl() can always be
relied upon.

 
     if (frame->eventHandler().keyEvent(evt)) {
         if (WebInputEvent::RawKeyDown == event.type) {