Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 663413002: Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, klundberg+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome. The original review thread is in https://codereview.chromium.org/588523002/ Fix the way how we create webrtc::AudioProcessing in Chrome. TBR=tommi@chromium.org,maruel@chromium.org BUG=415935 TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. Committed: https://crrev.com/79ef9085fbdbc8e09ac989ea4d5f4c28e516bba9 Cr-Commit-Position: refs/heads/master@{#300509}

Patch Set 1 : original code from 597923002 #

Patch Set 2 : use new API for the AEC dump. #

Patch Set 3 : fixed a rebased error. #

Patch Set 4 : removed two extra empty line caused by rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -13 lines) Patch
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
M content/content_unittests.isolate View 2 chunks +14 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 2 3 4 chunks +12 lines, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 5 chunks +20 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
no longer working on chromium
Hi Tommi and Marc, I am going to reland this as https://codereview.chromium.org/597923002, plus a fix ...
6 years, 2 months ago (2014-10-21 14:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663413002/40001
6 years, 2 months ago (2014-10-21 14:34:01 UTC) #5
no longer working on chromium
On 2014/10/21 14:34:01, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-21 15:02:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663413002/60001
6 years, 2 months ago (2014-10-21 15:12:57 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-21 17:16:52 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/79ef9085fbdbc8e09ac989ea4d5f4c28e516bba9 Cr-Commit-Position: refs/heads/master@{#300509}
6 years, 2 months ago (2014-10-21 17:17:38 UTC) #11
no longer working on chromium
6 years, 1 month ago (2014-11-12 14:10:42 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/717203002/ by xians@chromium.org.

The reason for reverting is: This CL broke the configuration of AudioProcessing,
we have to revert it to fix the echo issues it introduces..

Powered by Google App Engine
This is Rietveld 408576698