Reland 588523002: Fix the way how we create webrtc::AudioProcessing in Chrome

The original review thread is in https://codereview.chromium.org/588523002/

Fix the way how we create webrtc::AudioProcessing in Chrome.

TBR=tommi@chromium.org

BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.

Committed: https://chromium.googlesource.com/chromium/src/+/5ac9f35c3e5d9781a01769f3f0d0433026c57de7

[no longer working on chromium, 2014-09-24 09:15:28]

xians@chromium.org changed reviewers:
+ tommi@chromium.org

[no longer working on chromium, 2014-09-24 10:17:05]

Tommi, could you please review this?

Thanks,
SX

[tommi (sloooow) - chröme, 2014-09-24 10:54:23]

lgtm

[no longer working on chromium, 2014-09-24 11:07:24]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-24 11:08:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597923002/40001

[commit-bot: I haz the power, 2014-09-24 11:17:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 11:17:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no longer working on chromium, 2014-09-24 12:09:24]

xians@chromium.org changed reviewers:
+ jochen@chromium.org

[no longer working on chromium, 2014-09-24 12:09:24]

Jochen, can I have your owner stamp to the content_test.gypi and
content_unittests.isolate?

Thanks,
SX

[no longer working on chromium, 2014-09-24 12:55:19]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-24 12:55:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597923002/40001

[no longer working on chromium, 2014-09-24 13:03:30]

Hi Jochen, I saw your msg about that you would be slow for reviews, We need to
land it asap so that we can  merge it to M38, so I hope it is fine for me to
press the commit button to see if it passes the android_dbg_tests_recipe bot.
Please feel free to stop the commit if you find any problem.

Thanks,
SX

[no longer working on chromium, 2014-09-24 14:12:47]

The CQ bit was unchecked by xians@chromium.org

[no longer working on chromium, 2014-09-24 15:04:50]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-24 15:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597923002/60001

[commit-bot: I haz the power, 2014-09-24 15:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 15:32:29]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[no longer working on chromium, 2014-09-25 09:09:53]

xians@chromium.org changed reviewers:
+ maruel@chromium.org

[no longer working on chromium, 2014-09-25 09:09:54]

Hi Maruel, could you please look at the setup.py, content_tests.gypi and
content_unittests.isolate.

Thanks,
SX

[M-A Ruel, 2014-09-25 14:26:32]

maruel@chromium.org changed reviewers:
+ brettw@chromium.org

[M-A Ruel, 2014-09-25 14:26:33]

Why should libpeer_target_type != component be supported in the first place?

The less knobs, the better. I don't see value in this one, in particular that
you use "loadable_module" instead of "shared_library". Please sell it to me.

+Brett since it affects GN with yet-another-config variable

[tommi (sloooow) - chröme, 2014-09-25 14:51:35]

On 2014/09/25 14:26:33, M-A Ruel wrote:
> Why should libpeer_target_type != component be supported in the first place?
> 
> The less knobs, the better. I don't see value in this one, in particular that
> you use "loadable_module" instead of "shared_library". Please sell it to me.
> 
> +Brett since it affects GN with yet-another-config variable

Chrome ships with libpeerconnection.[dll|so], which is when we use
loadable_module.  Chromium statically links.

[tommi (sloooow) - chröme, 2014-09-25 14:52:18]

On 2014/09/25 14:51:35, tommi wrote:
> On 2014/09/25 14:26:33, M-A Ruel wrote:
> > Why should libpeer_target_type != component be supported in the first place?
> > 
> > The less knobs, the better. I don't see value in this one, in particular
that
> > you use "loadable_module" instead of "shared_library". Please sell it to me.
> > 
> > +Brett since it affects GN with yet-another-config variable
> 
> Chrome ships with libpeerconnection.[dll|so], which is when we use
> loadable_module.  Chromium statically links.

There's more information in the bug too :)

[M-A Ruel, 2014-09-25 15:22:00]

lgtm

Hopefully this will all disapear once we properly do runtime dependency
detection directly from the build rules also in release.

[no longer working on chromium, 2014-09-25 15:24:06]

On 2014/09/25 15:22:00, M-A Ruel wrote:
> lgtm
> 
> Hopefully this will all disapear once we properly do runtime dependency
> detection directly from the build rules also in release.

Thanks so much.

[no longer working on chromium, 2014-09-25 15:24:11]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-09-25 15:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597923002/80001

[commit-bot: I haz the power, 2014-09-25 15:30:16]

Committed patchset #5 (id:80001) as 5ac9f35c3e5d9781a01769f3f0d0433026c57de7

[commit-bot: I haz the power, 2014-09-25 15:30:46]

Patchset 5 (id:??) landed as
https://crrev.com/6299e2dbff65201b71f159d185a95d539ee9e810
Cr-Commit-Position: refs/heads/master@{#296709}

[no longer working on chromium, 2014-09-26 14:02:31]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/611493002/ by xians@chromium.org.

The reason for reverting is: It fails some aec dump content browser tests on
windows, and likely it also breaks the aec dump production code, it is safer to
revert it since cut happens today.
http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Te....