Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: content/renderer/media/media_stream_audio_processor_options.cc

Issue 663413002: Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed two extra empty line caused by rebasing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_audio_processor.cc ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_options.cc
diff --git a/content/renderer/media/media_stream_audio_processor_options.cc b/content/renderer/media/media_stream_audio_processor_options.cc
index 50eb6e2e6038ef43c4e36197840b0c121d6a1e66..cb4278d516c880241630035ce409cb41c239b80e 100644
--- a/content/renderer/media/media_stream_audio_processor_options.cc
+++ b/content/renderer/media/media_stream_audio_processor_options.cc
@@ -251,15 +251,10 @@ void EnableTypingDetection(AudioProcessing* audio_processing,
void StartEchoCancellationDump(AudioProcessing* audio_processing,
base::File aec_dump_file) {
DCHECK(aec_dump_file.IsValid());
-
- FILE* stream = base::FileToFILE(aec_dump_file.Pass(), "w");
- if (!stream) {
- LOG(ERROR) << "Failed to open AEC dump file";
- return;
- }
-
- if (audio_processing->StartDebugRecording(stream))
+ if (audio_processing->StartDebugRecordingForPlatformFile(
+ aec_dump_file.TakePlatformFile())) {
DLOG(ERROR) << "Fail to start AEC debug recording";
+ }
}
void StopEchoCancellationDump(AudioProcessing* audio_processing) {
« no previous file with comments | « content/renderer/media/media_stream_audio_processor.cc ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698