Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/DOMPresentationUtils.js
diff --git a/Source/devtools/front_end/components/DOMPresentationUtils.js b/Source/devtools/front_end/components/DOMPresentationUtils.js
index 4160af13ab02627c94f30301eebf683089849fb6..24def24dc7cc8caa3b1a10fc291045d21b9ddd4f 100644
--- a/Source/devtools/front_end/components/DOMPresentationUtils.js
+++ b/Source/devtools/front_end/components/DOMPresentationUtils.js
@@ -35,13 +35,13 @@ WebInspector.DOMPresentationUtils.decorateNodeLabel = function(node, parentEleme
{
var title = node.nodeNameInCorrectCase();
- var nameElement = document.createElement("span");
+ var nameElement = createElement("span");
nameElement.textContent = title;
parentElement.appendChild(nameElement);
var idAttribute = node.getAttribute("id");
if (idAttribute) {
- var idElement = document.createElement("span");
+ var idElement = createElement("span");
parentElement.appendChild(idElement);
var part = "#" + idAttribute;
@@ -58,7 +58,7 @@ WebInspector.DOMPresentationUtils.decorateNodeLabel = function(node, parentEleme
var foundClasses = {};
if (classes.length) {
- var classesElement = document.createElement("span");
+ var classesElement = createElement("span");
classesElement.className = "extra";
parentElement.appendChild(classesElement);
@@ -97,9 +97,9 @@ WebInspector.DOMPresentationUtils.createSpansForNodeTitle = function(container,
WebInspector.DOMPresentationUtils.linkifyNodeReference = function(node)
{
if (!node)
- return document.createTextNode(WebInspector.UIString("<node>"));
+ return createTextNode(WebInspector.UIString("<node>"));
- var link = document.createElement("span");
+ var link = createElement("span");
link.className = "node-link";
WebInspector.DOMPresentationUtils.decorateNodeLabel(node, link);
@@ -125,7 +125,7 @@ WebInspector.DOMPresentationUtils.buildImagePreviewContents = function(target, i
return;
}
- var imageElement = document.createElement("img");
+ var imageElement = createElement("img");
imageElement.addEventListener("load", buildContent, false);
imageElement.addEventListener("error", errorCallback, false);
resource.populateImageSource(imageElement);
@@ -138,7 +138,7 @@ WebInspector.DOMPresentationUtils.buildImagePreviewContents = function(target, i
function buildContent()
{
- var container = document.createElement("table");
+ var container = createElement("table");
container.className = "image-preview-container";
var naturalWidth = precomputedDimensions ? precomputedDimensions.naturalWidth : imageElement.naturalWidth;
var naturalHeight = precomputedDimensions ? precomputedDimensions.naturalHeight : imageElement.naturalHeight;
« no previous file with comments | « Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js ('k') | Source/devtools/front_end/components/FilterBar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698