Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 0043627e67e1b84b91fd8d5adeed37b142f3bb9c..30c9c79637b87c89aa1b93fed613e12bd325ae9a 100644
--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -160,7 +160,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
} else
message = "Paused on a \"%s\" breakpoint set on %s.";
- var element = document.createElement("span");
+ var element = createElement("span");
var formatters = {
s: function(substitution)
{
@@ -170,7 +170,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
function append(a, b)
{
if (typeof b === "string")
- b = document.createTextNode(b);
+ b = createTextNode(b);
element.appendChild(b);
}
WebInspector.formatLocalized(message, substitutions, formatters, "", append);
@@ -228,12 +228,12 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
*/
_createBreakpointElement: function(node, type, enabled)
{
- var element = document.createElement("li");
+ var element = createElement("li");
element._node = node;
element._type = type;
element.addEventListener("contextmenu", this._contextMenu.bind(this, node, type), true);
- var checkboxElement = document.createElement("input");
+ var checkboxElement = createElement("input");
checkboxElement.className = "checkbox-elem";
checkboxElement.type = "checkbox";
checkboxElement.checked = enabled;
@@ -241,14 +241,14 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
element._checkboxElement = checkboxElement;
element.appendChild(checkboxElement);
- var labelElement = document.createElement("span");
+ var labelElement = createElement("span");
element.appendChild(labelElement);
var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
linkifiedNode.classList.add("monospace");
labelElement.appendChild(linkifiedNode);
- var description = document.createElement("div");
+ var description = createElement("div");
description.className = "source-text";
description.textContent = this._breakpointTypeLabels[type];
labelElement.appendChild(description);
« no previous file with comments | « Source/devtools/front_end/audits/AuditsPanel.js ('k') | Source/devtools/front_end/components/DOMPresentationUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698