Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: Source/devtools/front_end/components/FilterBar.js

Issue 662793002: [DevTools] Replace usages of document with custom functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/FilterBar.js
diff --git a/Source/devtools/front_end/components/FilterBar.js b/Source/devtools/front_end/components/FilterBar.js
index f7a4769c80915af577d0de8388af9fc98efe934b..6cdc5a4e2bbda28cdc2e4596ada2a98f3425b6de 100644
--- a/Source/devtools/front_end/components/FilterBar.js
+++ b/Source/devtools/front_end/components/FilterBar.js
@@ -35,7 +35,7 @@
WebInspector.FilterBar = function()
{
this._filtersShown = false;
- this._element = document.createElement("div");
+ this._element = createElement("div");
this._element.className = "hbox";
this._filterButton = new WebInspector.StatusBarButton(WebInspector.UIString("Filter"), "filters-toggle", 3);
@@ -205,7 +205,7 @@ WebInspector.TextFilterUI = function(supportRegex)
this._supportRegex = !!supportRegex;
this._regex = null;
- this._filterElement = document.createElement("div");
+ this._filterElement = createElement("div");
this._filterElement.className = "filter-text-filter";
this._filterInputElement = /** @type {!HTMLInputElement} */ (this._filterElement.createChild("input", "search-replace toolbar-replace-control"));
@@ -462,7 +462,7 @@ WebInspector.TextFilterUI.SuggestionBuilder.prototype = {
*/
WebInspector.NamedBitSetFilterUI = function(items, setting)
{
- this._filtersElement = document.createElement("div");
+ this._filtersElement = createElement("div");
this._filtersElement.className = "filter-bitset-filter status-bar-item";
this._filtersElement.title = WebInspector.UIString("Use %s Click to select multiple types.", WebInspector.KeyboardShortcut.shortcutToString("", WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta));
@@ -592,14 +592,14 @@ WebInspector.NamedBitSetFilterUI.prototype = {
*/
WebInspector.ComboBoxFilterUI = function(options)
{
- this._filterElement = document.createElement("div");
+ this._filterElement = createElement("div");
this._filterElement.className = "filter-combobox-filter";
this._options = options;
this._filterComboBox = new WebInspector.StatusBarComboBox(this._filterChanged.bind(this));
for (var i = 0; i < options.length; ++i) {
var filterOption = options[i];
- var option = document.createElement("option");
+ var option = createElement("option");
option.text = filterOption.label;
option.title = filterOption.title;
this._filterComboBox.addOption(option);
@@ -675,7 +675,7 @@ WebInspector.ComboBoxFilterUI.prototype = {
*/
WebInspector.CheckboxFilterUI = function(className, title, activeWhenChecked, setting)
{
- this._filterElement = document.createElement("div");
+ this._filterElement = createElement("div");
this._filterElement.classList.add("filter-checkbox-filter", "filter-checkbox-filter-" + className);
this._activeWhenChecked = !!activeWhenChecked;
this._createCheckbox(title);
« no previous file with comments | « Source/devtools/front_end/components/DOMPresentationUtils.js ('k') | Source/devtools/front_end/components/FlameChart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698