Type conversion fixes, url/ edition.

Type conversion fixes, url/ edition.

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Committed: https://crrev.com/7b51db65f6419f7b17f75063b84fb1e84c2e7d01
Cr-Commit-Position: refs/heads/master@{#300358}

[Peter Kasting, 2014-10-17 01:50:15]

pkasting@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2014-10-17 17:31:17]

I was sure that your changes to url_canon.h wouldn't compile, but it turns out
it does because the code I was thinking of doesn't handle UTF-16 output
properly. It carefully writes UTF-8 characters into the wide characters. I'll
file a bug.

https://codereview.chromium.org/662713004/diff/1/url/url_canon.h
File url/url_canon.h (right):

https://codereview.chromium.org/662713004/diff/1/url/url_canon.h#newcode50
url/url_canon.h:50: inline void set(int offset, char ch) {
This should be "T" instead of char. Can you fix the "at" call above to do the
same?

[Peter Kasting, 2014-10-17 22:49:07]

PTAL.

https://codereview.chromium.org/662713004/diff/1/url/url_canon.h
File url/url_canon.h (right):

https://codereview.chromium.org/662713004/diff/1/url/url_canon.h#newcode50
url/url_canon.h:50: inline void set(int offset, char ch) {
On 2014/10/17 17:31:17, brettw wrote:
> This should be "T" instead of char. Can you fix the "at" call above to do the
> same?

Done.

[brettw, 2014-10-20 16:56:41]

lgtm

[Peter Kasting, 2014-10-20 20:37:51]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-10-20 20:39:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662713004/20001

[commit-bot: I haz the power, 2014-10-20 22:35:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 22:36:39]

Patchset 2 (id:??) landed as
https://crrev.com/7b51db65f6419f7b17f75063b84fb1e84c2e7d01
Cr-Commit-Position: refs/heads/master@{#300358}