url/url_canon_fileurl.cc - Issue 662713004: Type conversion fixes, url/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/url_canon_fileurl.cc

Issue 662713004: Type conversion fixes, url/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/url_canon_fileurl.cc

diff --git a/url/url_canon_fileurl.cc b/url/url_canon_fileurl.cc

index 1322be74e407be3b0e2de3c97bc30b318f8ece2f..6191f8f9b2ca13d66e0193112a81f94520563c52 100644

--- a/url/url_canon_fileurl.cc

+++ b/url/url_canon_fileurl.cc

@@ -40,7 +40,7 @@ int FileDoDriveSpec(const CHAR* spec, int begin, int end,

// Normalize Windows drive letters to uppercase

if (spec[after_slashes] >= 'a' && spec[after_slashes] <= 'z')

- output->push_back(spec[after_slashes] - 'a' + 'A');

+ output->push_back(static_cast<char>(spec[after_slashes] - 'a' + 'A'));

else

output->push_back(static_cast<char>(spec[after_slashes]));

« no previous file with comments | « url/url_canon.h ('k') | url/url_canon_pathurl.cc » ('j') | no next file with comments »