Type conversion fixes, url/ edition.

url/url_canon.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_URL_CANON_H_
 #define URL_URL_CANON_H_
 
 #include <stdlib.h>
 #include <string.h>
 
@@ skipping 29 matching lines @@
   virtual void Resize(int sz) = 0;
 
   // Accessor for returning a character at a given position. The input offset
   // must be in the valid range.
   inline char at(int offset) const {
     return buffer_[offset];
   }
 
   // Sets the character at the given position. The given position MUST be less
   // than the length().
-  inline void set(int offset, int ch) {
+  inline void set(int offset, char ch) {

[brettw, 2014/10/17 17:31:17]

This should be "T" instead of char. Can you fix the "at" call above to do the
same?

[Peter Kasting, 2014/10/17 22:49:07]

Done.

     buffer_[offset] = ch;
   }
 
   // Returns the number of characters currently in the buffer.
   inline int length() const {
     return cur_len_;
   }
 
   // Returns the current capacity of the buffer. The length() is the number of
   // characters that have been declared to be written, but the capacity() is
@@ skipping 822 matching lines @@
                                    bool base_is_file,
                                    const base::char16* relative_url,
                                    const Component& relative_component,
                                    CharsetConverter* query_converter,
                                    CanonOutput* output,
                                    Parsed* out_parsed);
 
 }  // namespace url
 
 #endif  // URL_URL_CANON_H_