Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 22849019: Unexpose -webkit-marquee-direction (Closed)

Created:
7 years, 4 months ago by Julien - ping for review
Modified:
7 years, 4 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darktears, eseidel, Mike Lawther (Google)
Visibility:
Public.

Description

Unexpose -webkit-marquee-direction This change introduces the concept of an internal CSS property that is only allowed when parsing the UA and internal inline stylesheets. The internal properties starts with -internal- and are not exposed to the web (checked by our existing webexposed/ tests + a new one to be sure). To ensure that the previous logic works, -webkit-marquee-direction was renamed to -internal-marquee-direction and thus unexposed from the web platform. BUG=274055 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -22 lines) Patch
LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
LayoutTests/webexposed/internal-properties-should-not-be-exposed.html View 1 chunk +28 lines, -0 lines 0 comments Download
LayoutTests/webexposed/internal-properties-should-not-be-exposed-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
Source/core/css/CSSComputedStyleDeclaration.cpp View 4 chunks +9 lines, -5 lines 0 comments Download
Source/core/css/CSSParser-in.cpp View 4 chunks +6 lines, -3 lines 0 comments Download
Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/CSSPropertyNames.in View 2 chunks +3 lines, -1 line 0 comments Download
Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLMarqueeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
Source/core/page/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/scripts/make_css_property_names.py View 7 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
7 years, 4 months ago (2013-08-16 22:31:10 UTC) #1
eseidel
lgtm Fantastic!
7 years, 4 months ago (2013-08-16 22:42:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22849019/1
7 years, 4 months ago (2013-08-16 22:43:11 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-17 01:36:38 UTC) #4
Message was sent while issue was closed.
Change committed as 156256

Powered by Google App Engine
This is Rietveld 408576698