Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2131)

Unified Diff: Source/modules/credentialmanager/FederatedCredential.cpp

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/FederatedCredential.cpp
diff --git a/Source/modules/credentialmanager/FederatedCredential.cpp b/Source/modules/credentialmanager/FederatedCredential.cpp
index e22aeab9e6fa51b2982439a1fd043f4c07e17864..f2456802e87961f87be0222196fd06f342a3c1bb 100644
--- a/Source/modules/credentialmanager/FederatedCredential.cpp
+++ b/Source/modules/credentialmanager/FederatedCredential.cpp
@@ -16,13 +16,13 @@ FederatedCredential* FederatedCredential::create(WebFederatedCredential* webFede
return new FederatedCredential(webFederatedCredential);
}
-FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatar, const String& federation, ExceptionState& exceptionState)
+FederatedCredential* FederatedCredential::create(const String& id, const String& federation, const String& name, const String& avatar, ExceptionState& exceptionState)
{
KURL avatarURL = parseStringAsURL(avatar, exceptionState);
KURL federationURL = parseStringAsURL(federation, exceptionState);
if (exceptionState.hadException())
return nullptr;
- return new FederatedCredential(id, name, avatarURL, federationURL);
+ return new FederatedCredential(id, federationURL, name, avatarURL);
}
FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCredential)
@@ -30,8 +30,8 @@ FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCre
{
}
-FederatedCredential::FederatedCredential(const String& id, const String& name, const KURL& avatar, const KURL& federation)
- : Credential(PlatformFederatedCredential::create(id, name, avatar, federation))
+FederatedCredential::FederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatar)
+ : Credential(PlatformFederatedCredential::create(id, federation, name, avatar))
{
}
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698