Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Unified Diff: Source/modules/credentialmanager/FederatedCredential.h

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/FederatedCredential.h
diff --git a/Source/modules/credentialmanager/FederatedCredential.h b/Source/modules/credentialmanager/FederatedCredential.h
index a86941c7c8b19ab520bd0a5edae70ad493fbbd6b..2161ed435ed00bef4893d7616015c8e22d0fa8dc 100644
--- a/Source/modules/credentialmanager/FederatedCredential.h
+++ b/Source/modules/credentialmanager/FederatedCredential.h
@@ -18,15 +18,25 @@ class WebFederatedCredential;
class FederatedCredential final : public Credential {
DEFINE_WRAPPERTYPEINFO();
public:
+ static FederatedCredential* create(const String& id, const String& federation, ExceptionState& exceptionState)
+ {
+ return create(id, federation, String(), String(), exceptionState);
+ }
+
+ static FederatedCredential* create(const String& id, const String& federation, const String& name, ExceptionState& exceptionState)
+ {
+ return create(id, federation, name, String(), exceptionState);
+ }
+
+ static FederatedCredential* create(const String& id, const String& federation, const String& name, const String& avatar, ExceptionState&);
static FederatedCredential* create(WebFederatedCredential*);
- static FederatedCredential* create(const String& id, const String& name, const String& avatar, const String& federation, ExceptionState&);
// FederatedCredential.idl
const KURL& federation() const;
private:
FederatedCredential(WebFederatedCredential*);
- FederatedCredential(const String& id, const String& name, const KURL& avatar, const KURL& federation);
+ FederatedCredential(const String& id, const KURL& federation, const String& name, const KURL& avatar);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698