Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/modules/credentialmanager/FederatedCredential.cpp

Issue 661973002: Credential Manager: JavaScript arguments make more sense in a different order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/credentialmanager/FederatedCredential.h" 6 #include "modules/credentialmanager/FederatedCredential.h"
7 7
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "platform/credentialmanager/PlatformFederatedCredential.h" 9 #include "platform/credentialmanager/PlatformFederatedCredential.h"
10 #include "public/platform/WebFederatedCredential.h" 10 #include "public/platform/WebFederatedCredential.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 FederatedCredential* FederatedCredential::create(WebFederatedCredential* webFede ratedCredential) 14 FederatedCredential* FederatedCredential::create(WebFederatedCredential* webFede ratedCredential)
15 { 15 {
16 return new FederatedCredential(webFederatedCredential); 16 return new FederatedCredential(webFederatedCredential);
17 } 17 }
18 18
19 FederatedCredential* FederatedCredential::create(const String& id, const String& name, const String& avatar, const String& federation, ExceptionState& exception State) 19 FederatedCredential* FederatedCredential::create(const String& id, const String& federation, const String& name, const String& avatar, ExceptionState& exception State)
20 { 20 {
21 KURL avatarURL = parseStringAsURL(avatar, exceptionState); 21 KURL avatarURL = parseStringAsURL(avatar, exceptionState);
22 KURL federationURL = parseStringAsURL(federation, exceptionState); 22 KURL federationURL = parseStringAsURL(federation, exceptionState);
23 if (exceptionState.hadException()) 23 if (exceptionState.hadException())
24 return nullptr; 24 return nullptr;
25 return new FederatedCredential(id, name, avatarURL, federationURL); 25 return new FederatedCredential(id, federationURL, name, avatarURL);
26 } 26 }
27 27
28 FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCre dential) 28 FederatedCredential::FederatedCredential(WebFederatedCredential* webFederatedCre dential)
29 : Credential(webFederatedCredential->platformCredential()) 29 : Credential(webFederatedCredential->platformCredential())
30 { 30 {
31 } 31 }
32 32
33 FederatedCredential::FederatedCredential(const String& id, const String& name, c onst KURL& avatar, const KURL& federation) 33 FederatedCredential::FederatedCredential(const String& id, const KURL& federatio n, const String& name, const KURL& avatar)
34 : Credential(PlatformFederatedCredential::create(id, name, avatar, federatio n)) 34 : Credential(PlatformFederatedCredential::create(id, federation, name, avata r))
35 { 35 {
36 } 36 }
37 37
38 const KURL& FederatedCredential::federation() const 38 const KURL& FederatedCredential::federation() const
39 { 39 {
40 return static_cast<PlatformFederatedCredential*>(m_platformCredential.get()) ->federation(); 40 return static_cast<PlatformFederatedCredential*>(m_platformCredential.get()) ->federation();
41 } 41 }
42 42
43 } // namespace blink 43 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698