Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 66193004: Reland 17588: Add signed/unsigned 8-bit and 16-bit Representations to Crankshaft (Closed)

Created:
7 years, 1 month ago by danno
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Reland 17588: Add signed/unsigned 8-bit and 16-bit Representations to Crankshaft R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17606

Patch Set 1 #

Patch Set 2 : The right patch #

Patch Set 3 : Make it work #

Patch Set 4 : Add missing files #

Patch Set 5 : Fix stuff #

Patch Set 6 : More fixes #

Patch Set 7 : This is it. I'm sure of it. #

Patch Set 8 : Fix test case #

Patch Set 9 : Latest version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -80 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 5 chunks +5 lines, -25 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +11 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 5 chunks +5 lines, -28 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M src/property-details.h View 6 chunks +35 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 1 chunk +97 lines, -0 lines 0 comments Download
A test/cctest/test-macro-assembler-ia32.cc View 1 2 3 1 chunk +140 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 2 chunks +43 lines, -2 lines 0 comments Download
A test/cctest/test-representation.cc View 1 2 3 1 chunk +124 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
Ulan, can you please verify that this actually compiles/runs on real ARM hardware
7 years, 1 month ago (2013-11-08 14:37:03 UTC) #1
ulan
On 2013/11/08 14:37:03, danno wrote: > Ulan, can you please verify that this actually compiles/runs ...
7 years, 1 month ago (2013-11-08 15:43:37 UTC) #2
ulan
lgtm
7 years, 1 month ago (2013-11-08 17:35:39 UTC) #3
danno
7 years, 1 month ago (2013-11-08 17:36:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #9 manually as r17606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698