Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 66193004: Reland 17588: Add signed/unsigned 8-bit and 16-bit Representations to Crankshaft (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Latest version Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2416 matching lines...) Expand 10 before | Expand all | Expand 10 after
2427 obj = needs_write_barrier_for_map 2427 obj = needs_write_barrier_for_map
2428 ? UseRegister(instr->object()) 2428 ? UseRegister(instr->object())
2429 : UseRegisterAtStart(instr->object()); 2429 : UseRegisterAtStart(instr->object());
2430 } 2430 }
2431 2431
2432 bool can_be_constant = instr->value()->IsConstant() && 2432 bool can_be_constant = instr->value()->IsConstant() &&
2433 HConstant::cast(instr->value())->NotInNewSpace() && 2433 HConstant::cast(instr->value())->NotInNewSpace() &&
2434 !(FLAG_track_double_fields && instr->field_representation().IsDouble()); 2434 !(FLAG_track_double_fields && instr->field_representation().IsDouble());
2435 2435
2436 LOperand* val; 2436 LOperand* val;
2437 if (instr->field_representation().IsByte()) { 2437 if (instr->field_representation().IsInteger8() ||
2438 instr->field_representation().IsUInteger8()) {
2438 // mov_b requires a byte register (i.e. any of eax, ebx, ecx, edx). 2439 // mov_b requires a byte register (i.e. any of eax, ebx, ecx, edx).
2439 // Just force the value to be in eax and we're safe here. 2440 // Just force the value to be in eax and we're safe here.
2440 val = UseFixed(instr->value(), eax); 2441 val = UseFixed(instr->value(), eax);
2441 } else if (needs_write_barrier) { 2442 } else if (needs_write_barrier) {
2442 val = UseTempRegister(instr->value()); 2443 val = UseTempRegister(instr->value());
2443 } else if (can_be_constant) { 2444 } else if (can_be_constant) {
2444 val = UseRegisterOrConstant(instr->value()); 2445 val = UseRegisterOrConstant(instr->value());
2445 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) { 2446 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) {
2446 val = UseTempRegister(instr->value()); 2447 val = UseTempRegister(instr->value());
2447 } else if (FLAG_track_double_fields && 2448 } else if (FLAG_track_double_fields &&
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
2748 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2749 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2749 LOperand* object = UseRegister(instr->object()); 2750 LOperand* object = UseRegister(instr->object());
2750 LOperand* index = UseTempRegister(instr->index()); 2751 LOperand* index = UseTempRegister(instr->index());
2751 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2752 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2752 } 2753 }
2753 2754
2754 2755
2755 } } // namespace v8::internal 2756 } } // namespace v8::internal
2756 2757
2757 #endif // V8_TARGET_ARCH_IA32 2758 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698