Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 661733002: SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr This is a bug that I introduced in r164832. This caused SMIL animation targeting <marker>'s refY to animate refX attribute instead. TEST=svg/markers/animate-refY.svg BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183818

Patch Set 1 #

Patch Set 2 : add LayoutTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A LayoutTests/svg/markers/animate-refY.svg View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/markers/animate-refY-expected.svg View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kouhei (in TOK)
PTAL. This is bug fix from a typo I introduced 9 months ago ( ﹡゚ー゚﹡)
6 years, 2 months ago (2014-10-16 12:47:24 UTC) #3
haraken
LGTM
6 years, 2 months ago (2014-10-16 13:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661733002/20001
6 years, 2 months ago (2014-10-16 14:22:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:29:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183818

Powered by Google App Engine
This is Rietveld 408576698