Source/core/svg/SVGMarkerElement.cpp - Issue 661733002: SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGMarkerElement.cpp

Issue 661733002: SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add LayoutTest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGMarkerElement.cpp

diff --git a/Source/core/svg/SVGMarkerElement.cpp b/Source/core/svg/SVGMarkerElement.cpp

index 1c6fad94a34981728beb1fd3ac21f2b2cd743476..61274d6496535f5f0c9a18b30f1d6e63ae2ecca9 100644

--- a/Source/core/svg/SVGMarkerElement.cpp

+++ b/Source/core/svg/SVGMarkerElement.cpp

@@ -44,7 +44,7 @@ inline SVGMarkerElement::SVGMarkerElement(Document& document)

: SVGElement(SVGNames::markerTag, document)

, SVGFitToViewBox(this)

, m_refX(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths))

- , m_refY(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths))

+ , m_refY(SVGAnimatedLength::create(this, SVGNames::refYAttr, SVGLength::create(LengthModeHeight), AllowNegativeLengths))

, m_markerWidth(SVGAnimatedLength::create(this, SVGNames::markerWidthAttr, SVGLength::create(LengthModeWidth), ForbidNegativeLengths))

, m_markerHeight(SVGAnimatedLength::create(this, SVGNames::markerHeightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths))

, m_orientAngle(SVGAnimatedAngle::create(this))

« no previous file with comments | « LayoutTests/svg/markers/animate-refY-expected.svg ('k') | no next file » | no next file with comments »