Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: Source/core/svg/SVGMarkerElement.cpp

Issue 661733002: SVGMarkerElement::m_refY should be bound to refY attr rather than refX attr (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add LayoutTest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/markers/animate-refY-expected.svg ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 26 matching lines...) Expand all
37 entries.append(std::make_pair(SVGMarkerUnitsStrokeWidth, "strokeWidth")) ; 37 entries.append(std::make_pair(SVGMarkerUnitsStrokeWidth, "strokeWidth")) ;
38 } 38 }
39 return entries; 39 return entries;
40 } 40 }
41 41
42 42
43 inline SVGMarkerElement::SVGMarkerElement(Document& document) 43 inline SVGMarkerElement::SVGMarkerElement(Document& document)
44 : SVGElement(SVGNames::markerTag, document) 44 : SVGElement(SVGNames::markerTag, document)
45 , SVGFitToViewBox(this) 45 , SVGFitToViewBox(this)
46 , m_refX(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::crea te(LengthModeWidth), AllowNegativeLengths)) 46 , m_refX(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::crea te(LengthModeWidth), AllowNegativeLengths))
47 , m_refY(SVGAnimatedLength::create(this, SVGNames::refXAttr, SVGLength::crea te(LengthModeWidth), AllowNegativeLengths)) 47 , m_refY(SVGAnimatedLength::create(this, SVGNames::refYAttr, SVGLength::crea te(LengthModeHeight), AllowNegativeLengths))
48 , m_markerWidth(SVGAnimatedLength::create(this, SVGNames::markerWidthAttr, S VGLength::create(LengthModeWidth), ForbidNegativeLengths)) 48 , m_markerWidth(SVGAnimatedLength::create(this, SVGNames::markerWidthAttr, S VGLength::create(LengthModeWidth), ForbidNegativeLengths))
49 , m_markerHeight(SVGAnimatedLength::create(this, SVGNames::markerHeightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths)) 49 , m_markerHeight(SVGAnimatedLength::create(this, SVGNames::markerHeightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths))
50 , m_orientAngle(SVGAnimatedAngle::create(this)) 50 , m_orientAngle(SVGAnimatedAngle::create(this))
51 , m_markerUnits(SVGAnimatedEnumeration<SVGMarkerUnitsType>::create(this, SVG Names::markerUnitsAttr, SVGMarkerUnitsStrokeWidth)) 51 , m_markerUnits(SVGAnimatedEnumeration<SVGMarkerUnitsType>::create(this, SVG Names::markerUnitsAttr, SVGMarkerUnitsStrokeWidth))
52 { 52 {
53 // Spec: If the markerWidth/markerHeight attribute is not specified, the eff ect is as if a value of "3" were specified. 53 // Spec: If the markerWidth/markerHeight attribute is not specified, the eff ect is as if a value of "3" were specified.
54 m_markerWidth->setDefaultValueAsString("3"); 54 m_markerWidth->setDefaultValueAsString("3");
55 m_markerHeight->setDefaultValueAsString("3"); 55 m_markerHeight->setDefaultValueAsString("3");
56 56
57 addToPropertyMap(m_refX); 57 addToPropertyMap(m_refX);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 bool SVGMarkerElement::selfHasRelativeLengths() const 164 bool SVGMarkerElement::selfHasRelativeLengths() const
165 { 165 {
166 return m_refX->currentValue()->isRelative() 166 return m_refX->currentValue()->isRelative()
167 || m_refY->currentValue()->isRelative() 167 || m_refY->currentValue()->isRelative()
168 || m_markerWidth->currentValue()->isRelative() 168 || m_markerWidth->currentValue()->isRelative()
169 || m_markerHeight->currentValue()->isRelative(); 169 || m_markerHeight->currentValue()->isRelative();
170 } 170 }
171 171
172 } // namespace blink 172 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/svg/markers/animate-refY-expected.svg ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698