Issue 661603009: Revert of Support GLSL es 3.00

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661603009: Revert of Support GLSL es 3.00 (Closed)

Created:
6 years, 2 months ago by rmistry

Modified:
6 years, 2 months ago

Reviewers:
joshualitt, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Support GLSL es 3.00 (patchset #5 id:80001 of https://codereview.chromium.org/659443007/) Reason for revert: Trying to fix DEPS roll failure: https://codereview.chromium.org/660113002/ Link to failing builds: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578 http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354 Original issue's description: > Support GLSL es 3.00 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/62372bcc6abe3537dac98dd9b9172cf3b85afa2b TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/79b2b1fb12202d22411b607a095cb26c6e4fe8b7

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -51 lines)			Patch
M	src/gpu/gl/GrGLCaps.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.cpp	View	3 chunks	+3 lines, -21 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderVar.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp	View	4 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661603009/1

6 years, 2 months ago (2014-10-17 12:14:18 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 79b2b1fb12202d22411b607a095cb26c6e4fe8b7

6 years, 2 months ago (2014-10-17 12:14:35 UTC) #3

rmistry

6 years, 2 months ago (2014-10-17 13:06:40 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/647043005/ by rmistry@google.com.

The reason for reverting is: DEPS roll still failing:
https://codereview.chromium.org/661993002/

Reverting the revert..

Expand Messages | Collapse Messages