Include all hung bots alerts in Trooper tree.

Include all hung bots alerts in Trooper tree.

Currently, chromium hung bots and blink hung bots are shown in their
corresponding views. With this change, all hung bots will show up in the Trooper
view. This includes the chromium and blink ones, but also others other trees
(e.g. non-closers).

BUG=412189
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183850

[navabi, 2014-10-15 23:52:43]

navabi@google.com changed reviewers:
+ eseidel@chromium.org, leviw@chromium.org, ojan@chromium.org

[leviw_travelin_and_unemployed, 2014-10-16 00:03:25]

Please add a test that covers this change :)

[navabi, 2014-10-16 08:38:28]

Thanks Levi. Test added. PTAL.

[leviw_travelin_and_unemployed, 2014-10-16 18:23:48]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2014-10-16 18:23:49]

lgtm

[commit-bot: I haz the power, 2014-10-16 18:24:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661463004/80001

[commit-bot: I haz the power, 2014-10-16 18:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:31:34]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[ojan, 2014-10-16 21:19:22]

lgtm

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-failures.html (right):

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-failures.html:166: //Add any failures that should
be listed in the trooper view.
This comment doesn't really tell you anything other than what the code obviously
does. Also, missing a space after the //.

[ojan, 2014-10-16 21:20:39]

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/test/ct-failures-tests.html (right):

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/test/ct-failures-tests.html:431: var emptygd = new
CTStepFailureGroupData([], emptycl);
We've been avoiding acronyms except for standard ones like HTML and XML. I'd
just call this emptyCommit and emptyGroupData. It makes the code more readable.

[navabi, 2014-10-16 23:56:05]

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-failures.html (right):

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-failures.html:166: //Add any failures that should
be listed in the trooper view.
On 2014/10/16 21:19:22, ojan-only-code-yellow-reviews wrote:
> This comment doesn't really tell you anything other than what the code
obviously
> does. Also, missing a space after the //.

Removed.

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/test/ct-failures-tests.html (right):

https://codereview.chromium.org/661463004/diff/80001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/test/ct-failures-tests.html:431: var emptygd = new
CTStepFailureGroupData([], emptycl);
On 2014/10/16 21:20:39, ojan-only-code-yellow-reviews wrote:
> We've been avoiding acronyms except for standard ones like HTML and XML. I'd
> just call this emptyCommit and emptyGroupData. It makes the code more
readable.

Done.

[navabi, 2014-10-17 00:00:29]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2014-10-17 00:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/661463004/100001

[commit-bot: I haz the power, 2014-10-17 02:06:48]

Committed patchset #6 (id:100001) as 183850